Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:99494
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.213.173 as permitted sender)
MIME-Version: 1.0
Sender: jakub.php@gmail.com
In-Reply-To: <20170607125449.GA9868@gmail.com>
References: <20170531101952.GB26690@gmail.com> <CAEKnhAF-NnxvwmgVzZuKitKZJu1cUTK+9dKzuido22s373m73w@mail.gmail.com>
 <20170604182219.GA6723@gmail.com> <CAEKnhAG=i0DKfa8E9cfFqE2DoO8p08WcYkm00+Z=ib5fEfGsig@mail.gmail.com>
 <20170607125449.GA9868@gmail.com>
Date: Sun, 11 Jun 2017 18:45:18 +0100
Message-ID: <CAEKnhAEphc3Yw43i-dPEPLp+KEj1BNXJGGpoYzx2xvJ5ENgsow@mail.gmail.com>
To: Jelle van der Waa <jelle@vdwaa.nl>
Cc: php-internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="94eb2c0b20580a179c0551b2c461"
Subject: Re: [PHP-DEV] [RFC] Add openssl_pkcs7_read and extend openssl_pkcs7_verify
From: bukka@php.net (Jakub Zelenka)

--94eb2c0b20580a179c0551b2c461
Content-Type: text/plain; charset="UTF-8"

Hi,

On Wed, Jun 7, 2017 at 1:54 PM, Jelle van der Waa <jelle@vdwaa.nl> wrote:
>
>
> Another thing I would want to work on is making the openssl_pkcs7_*
> functions in memory instead of file based. This would increase the
> security concerns since that means it won't save plaintext temporarily to
> file.
>
> An attempt for that has been made in a PR, but was closed. Is the PR on
> the right 'track' or can the current functions change to accept either a
> string or a filename? (I'm not 100% if PHP internals allow that) or if
> it's really wanted. [1]
>
> [1] https://github.com/php/php-src/pull/560
>
>
I think that it makes sense to add it. Just one correction to my comment in
that PR. It seems probably more consistent with reference as it like that
in *_export_to_file functions.

Probably best to create a PR and then send a new email (new thread) and
just wait a little bit ;)

Cheers

Jakub

--94eb2c0b20580a179c0551b2c461--