Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:99436
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zeyos.com designates 88.99.153.70 as permitted sender)
Date: Wed, 07 Jun 2017 19:15:01 +0200
To: Dmitry Stogov <dmitry@zend.com>
Cc: PHP Internals <internals@lists.php.net>,  	Xinchen Hui <xinchen.h@zend.com>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Message-ID: <20170607171502.0E59574D18@mx.zeyos.com>
Subject: Basic string comparison functions still use old parameter parsing API
From: ben.coutu@zeyos.com (Benjamin Coutu)

Hi Dmitry,=0A=0AI just noticed that all basic string comparison functions i=
n Zend/zend_builtin_functions.c, especially "strcmp", "strncmp", "strcasecm=
p", "strncasecmp" still use the old and inefficient parameter parsing API, =
unlike similar functions in ext/standard/string.c such as "substr_compare",=
 "strtok", "str(i)str", "str(i)pos", "strr(i)pos", "strrchr" that already c=
onsistently use the new efficient macro-based API.=0A=0AI think one can con=
sider "str(n)cmp" and "str(n)casecmp", etc. at least as important as "subst=
r_compare", especially considering that these are wrappers around very basi=
c functions that often get called in very hot code or inside tight loops (e=
.g. sorting). I therefore recommend changing those 4 functions in Zend/zend=
_builtin_functions.c to use ZEND_PARSE_PARAMETERS_* macros for PHP 7.2.=0A=
=0AWhat do you think?=0A=0A-- =0A=0ABenjamin Coutu=0AZeyOS, Inc.