Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:9941 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 27409 invoked by uid 1010); 18 May 2004 13:09:15 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 27320 invoked from network); 18 May 2004 13:09:14 -0000 Received: from unknown (HELO is.magroup.ru) (213.33.179.242) by pb1.pair.com with SMTP; 18 May 2004 13:09:14 -0000 Received: from localhost.localdomain ([192.168.3.226]) by is.magroup.ru with Microsoft SMTPSVC(5.0.2195.6713); Tue, 18 May 2004 17:09:43 +0400 Date: Tue, 18 May 2004 17:09:42 +0400 To: internals@lists.php.net Message-ID: <20040518170942.19e69489.tony2001@phpclub.net> In-Reply-To: References: <20040518162143.0c2c10a9.tony2001@phpclub.net> X-Mailer: Sylpheed version 0.9.10cvs12 (GTK+ 1.2.10; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 18 May 2004 13:09:43.0116 (UTC) FILETIME=[627D38C0:01C43CD9] Subject: Re: [PHP-DEV] setting LC_ALL to it's current value during startup From: tony2001@phpclub.net (Antony Dovgal) On Tue, 18 May 2004 13:55:18 +0100 "Wez Furlong" wrote: > Hey Antony, > > This is most likely due to some issues with serialize/unserialize and floating > point numbers; we don't want the format to change with the locale, since it > should be independent. > > Yes, it is a mess :) ok. but in this case we can set all except LC_NUMERIC and it should not affect floats. so, the patch should look like this: Index: main.c =================================================================== RCS file: /repository/php-src/main/main.c,v retrieving revision 1.601 diff -u -r1.601 main.c --- main.c 24 Mar 2004 13:33:26 -0000 1.601 +++ main.c 18 May 2004 13:08:18 -0000 @@ -1365,7 +1365,12 @@ PG(disable_classes) = NULL; #if HAVE_SETLOCALE + setlocale(LC_COLLATE, ""); setlocale(LC_CTYPE, ""); + setlocale(LC_MESSAGES, ""); + setlocale(LC_MONETARY, ""); + setlocale(LC_TIME, ""); + /* LC_NUMERIC is not set due to some issues with serialize/unserialize */ #endif #if HAVE_TZSET --- WBR, Antony Dovgal aka tony2001 tony2001@phpclub.net || antony@dovgal.com