Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:9938 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 81260 invoked by uid 1010); 18 May 2004 12:55:24 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 81226 invoked from network); 18 May 2004 12:55:23 -0000 Received: from unknown (HELO mx.thebrainroom.net) (65.200.24.98) by pb1.pair.com with SMTP; 18 May 2004 12:55:23 -0000 Received: by mx.thebrainroom.net (Postfix, from userid 517) id 11F3E14880BF; Tue, 18 May 2004 05:55:21 -0700 (PDT) Received: from tron (obsidian.thebrainroom.net [82.133.1.142]) (using TLSv1 with cipher RC4-MD5 (128/128 bits)) (No client certificate requested) by mx.thebrainroom.net (Postfix) with ESMTP id 105FB148809B; Tue, 18 May 2004 05:55:19 -0700 (PDT) To: "'Antony Dovgal'" , "'php-dev'" Date: Tue, 18 May 2004 13:55:18 +0100 Organization: The Brain Room Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook, Build 11.0.5510 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2800.1409 In-Reply-To: <20040518162143.0c2c10a9.tony2001@phpclub.net> Thread-Index: AcQ80qFKxhcQ2XqUQtuORRE4TsRUtgABHatQ Message-ID: X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on jc.thebrainroom.net X-Spam-Status: No, hits=1.1 required=5.0 tests=MAILTO_TO_SPAM_ADDR autolearn=no version=2.63 X-Spam-Level: * X-TBR-Filter: Virus scanned and defanged Subject: RE: [PHP-DEV] setting LC_ALL to it's current value during startup From: wez@thebrainroom.com ("Wez Furlong") References: <20040518162143.0c2c10a9.tony2001@phpclub.net> Hey Antony, This is most likely due to some issues with serialize/unserialize and floating point numbers; we don't want the format to change with the locale, since it should be independent. Yes, it is a mess :) --Wez. > -----Original Message----- > From: Antony Dovgal [mailto:tony2001@phpclub.net] > Sent: 18 May 2004 13:22 > To: php-dev > Subject: [PHP-DEV] setting LC_ALL to it's current value during startup > > Hi all! > > Could somebody explain me why we're setting only LC_CTYPE to > it's current value in main/main.c, line 1368 ? > What is the reason to make all users to call setlocale() > explicitly to set LC_ALL ? > > Of course, there can be some reasons I'm unaware of, but I'd > like to propose following tiny patch: > > Index: main.c > =================================================================== > RCS file: /repository/php-src/main/main.c,v > retrieving revision 1.601 > diff -u -r1.601 main.c > --- main.c 24 Mar 2004 13:33:26 -0000 1.601 > +++ main.c 18 May 2004 12:14:12 -0000 > @@ -1365,7 +1365,7 @@ > PG(disable_classes) = NULL; > > #if HAVE_SETLOCALE > - setlocale(LC_CTYPE, ""); > + setlocale(LC_ALL, ""); > #endif > > --- > WBR, > Antony Dovgal aka tony2001 > tony2001@phpclub.net || antony@dovgal.com > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > >