Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:9936 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 75464 invoked by uid 1010); 18 May 2004 12:21:16 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 75437 invoked from network); 18 May 2004 12:21:15 -0000 Received: from unknown (HELO is.magroup.ru) (213.33.179.242) by pb1.pair.com with SMTP; 18 May 2004 12:21:15 -0000 Received: from localhost.localdomain ([192.168.3.226]) by is.magroup.ru with Microsoft SMTPSVC(5.0.2195.6713); Tue, 18 May 2004 16:21:43 +0400 Date: Tue, 18 May 2004 16:21:43 +0400 To: php-dev Message-ID: <20040518162143.0c2c10a9.tony2001@phpclub.net> X-Mailer: Sylpheed version 0.9.10cvs12 (GTK+ 1.2.10; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 18 May 2004 12:21:43.0850 (UTC) FILETIME=[AE5018A0:01C43CD2] Subject: setting LC_ALL to it's current value during startup From: tony2001@phpclub.net (Antony Dovgal) Hi all! Could somebody explain me why we're setting only LC_CTYPE to it's current value in main/main.c, line 1368 ? What is the reason to make all users to call setlocale() explicitly to set LC_ALL ? Of course, there can be some reasons I'm unaware of, but I'd like to propose following tiny patch: Index: main.c =================================================================== RCS file: /repository/php-src/main/main.c,v retrieving revision 1.601 diff -u -r1.601 main.c --- main.c 24 Mar 2004 13:33:26 -0000 1.601 +++ main.c 18 May 2004 12:14:12 -0000 @@ -1365,7 +1365,7 @@ PG(disable_classes) = NULL; #if HAVE_SETLOCALE - setlocale(LC_CTYPE, ""); + setlocale(LC_ALL, ""); #endif --- WBR, Antony Dovgal aka tony2001 tony2001@phpclub.net || antony@dovgal.com