Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:99339
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain basereality.com from 209.85.192.176 cause and error)
MIME-Version: 1.0
In-Reply-To: <e1567402-5e2c-d7ee-583c-30e40a818e70@tekwire.net>
References: <1e99c642-e3b8-3445-82ac-f6cb6258e0b4@php.net> <CA+kxMuTseKk4S5WwBd-cHDAPe6EOs-8rNyksG0Sje=XLYBPU_Q@mail.gmail.com>
 <e1567402-5e2c-d7ee-583c-30e40a818e70@tekwire.net>
Date: Sat, 3 Jun 2017 14:34:37 +0100
Message-ID: <CA+kxMuRuSwSviZ9bNZq9Que7iuPCd6V7hLuR1LMb-hSmnHesYw@mail.gmail.com>
To: =?UTF-8?Q?Fran=C3=A7ois_Laupretre?= <francois@tekwire.net>
Cc: Internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] [RFC][Discussion] Add support for stream-wrapped URLs
 in opcode cache
From: danack@basereality.com (Dan Ackroyd)

On 2 June 2017 at 17:31, Fran=C3=A7ois Laupretre <francois@tekwire.net> wro=
te:
> Hi Dan,
>
> Thanks for your comments. Both are fixed now.
>

Awesome.

btw it's my belief that very boring technical discussions about RFC
pull requests are best done via the github comments, both to reduce
the noise on this list and also so that people are can be precise, as
to which line they are talking about. I can't see any other RFCs that
had mundane code issues discussed on the list.

However as you declined to respond on Github, I'll ask here again:

1) Why is the patch checking for PHP's own version? This doesn't occur
anywhere else in the code

2) Why does the patch modify PHP_API_VERSION, which was already
modified for PHP 7.2

Additionally, the section for 'Backward Incompatible Changes' has
'None' listed - but then it lists some required modifications in "To
Existing Extensions" - won't non-core PHP extensions also be affected
by this RFC?

cheers
Dan