Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:99329
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.217.182 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <3A1C5448-F0A0-481E-8B42-3C47E5D6AB64@gmail.com>
References: <CAB8JV1Pub_6ppV_2Nub90z0kpfKZikmxvg-aUUB6SQHSqC34vQ@mail.gmail.com>
 <CA+kxMuQr0iu52yXsgUk82CTN-3h4NfJx+3xC3FREUTaYFiKZ1g@mail.gmail.com>
 <CAB8JV1NWbotD-pWOptY7TX4rMWWzaH9x8Z1Ztfumb7Q4bFeWUg@mail.gmail.com>
 <1496415412.4363.66.camel@schlueters.de> <CAEUnE0evXQYN_pAS-HPEGM-BT-DcK=VT0WyYPAVeHyXfpMY7sg@mail.gmail.com>
 <CAFMT4NqqRcAKg0rcwgGRiY_uvwPt=D3VU_2WSUN-H00kgh6-qw@mail.gmail.com> <3A1C5448-F0A0-481E-8B42-3C47E5D6AB64@gmail.com>
Date: Fri, 2 Jun 2017 14:05:03 -0400
Message-ID: <CAEUnE0d3wZ=4qrGsmAcmL96nSpYd+GqDF=zSqEcnGo3iab2eZg@mail.gmail.com>
To: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="94eb2c1be38419946c0550fdfebd"
Subject: Re: [PHP-DEV] RFC proposal
From: tendoaki@gmail.com (Michael Morris)

--94eb2c1be38419946c0550fdfebd
Content-Type: text/plain; charset="UTF-8"

On Fri, Jun 2, 2017 at 1:36 PM, Rowan Collins <rowan.collins@gmail.com>
wrote:

> On 2 June 2017 18:21:34 BST, Levi Morrison <levim@php.net> wrote:
> >On Fri, Jun 2, 2017 at 11:12 AM, Michael Morris <tendoaki@gmail.com>
> >wrote:
> >> What about foreach by reference, which is honestly the only time I
> >use
> >> referencing anymore...
> >>
> >> foreach ($array as $key => &$value) {
> >>   $value = someOp($value);
> >> }
> >>
> >> Is this also bad?
> >
> >I'm not going to say "bad" but I would not personally write it that
> >way. If the memory cost is too high to duplicate then ...
>
> The times I've used foreach-by-reference have absolutely nothing to do
> with memory cost. Mostly, they're situations where explicitly writing back
> into the original array would be tediously long-winded, like this:
>
> $some_array[$some_outer_key][$loop_key]['foo'] =
> some_func($loop_value['foo']);
> $some_array[$some_outer_key][$loop_key]['bar'] =
> some_other_func($loop_value['bar'], true);
>
> Granted, there are probably major refactorings that would be in some way
> better, but changing $loop_value to a reference gives the much more
> readable:
>
> $loop_value['foo'] = some_func($loop_value['foo']);
> $loop_value['bar'] = some_other_func($loop_value['bar'], true);
>
> References are fiddly, but they do have their uses. Short of eliminating
> mutability, per functional programming, I think they'll always have their
> place, in some form.
>
> Regards,
>
> --
> Rowan Collins
> [IMSoP]
>


Same here.  I was just trying to keep my example simple. I agree that a
generator, or even better array_map, would be a better way to deal with the
simplistic example I gave.

--94eb2c1be38419946c0550fdfebd--