Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:99328
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.128.174 as permitted sender)
Date: Fri, 02 Jun 2017 18:36:51 +0100
User-Agent: K-9 Mail for Android
In-Reply-To: <CAFMT4NqqRcAKg0rcwgGRiY_uvwPt=D3VU_2WSUN-H00kgh6-qw@mail.gmail.com>
References: <CAB8JV1Pub_6ppV_2Nub90z0kpfKZikmxvg-aUUB6SQHSqC34vQ@mail.gmail.com> <CA+kxMuQr0iu52yXsgUk82CTN-3h4NfJx+3xC3FREUTaYFiKZ1g@mail.gmail.com> <CAB8JV1NWbotD-pWOptY7TX4rMWWzaH9x8Z1Ztfumb7Q4bFeWUg@mail.gmail.com> <1496415412.4363.66.camel@schlueters.de> <CAEUnE0evXQYN_pAS-HPEGM-BT-DcK=VT0WyYPAVeHyXfpMY7sg@mail.gmail.com> <CAFMT4NqqRcAKg0rcwgGRiY_uvwPt=D3VU_2WSUN-H00kgh6-qw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
To: internals@lists.php.net
Message-ID: <3A1C5448-F0A0-481E-8B42-3C47E5D6AB64@gmail.com>
Subject: Re: [PHP-DEV] RFC proposal
From: rowan.collins@gmail.com (Rowan Collins)

On 2 June 2017 18:21:34 BST, Levi Morrison <levim@php=2Enet> wrote:
>On Fri, Jun 2, 2017 at 11:12 AM, Michael Morris <tendoaki@gmail=2Ecom>
>wrote:
>> What about foreach by reference, which is honestly the only time I
>use
>> referencing anymore=2E=2E=2E
>>
>> foreach ($array as $key =3D> &$value) {
>>   $value =3D someOp($value);
>> }
>>
>> Is this also bad?
>
>I'm not going to say "bad" but I would not personally write it that
>way=2E If the memory cost is too high to duplicate then =2E=2E=2E

The times I've used foreach-by-reference have absolutely nothing to do wit=
h memory cost=2E Mostly, they're situations where explicitly writing back i=
nto the original array would be tediously long-winded, like this:

$some_array[$some_outer_key][$loop_key]['foo'] =3D some_func($loop_value['=
foo']);
$some_array[$some_outer_key][$loop_key]['bar'] =3D some_other_func($loop_v=
alue['bar'], true);

Granted, there are probably major refactorings that would be in some way b=
etter, but changing $loop_value to a reference gives the much more readable=
:

$loop_value['foo'] =3D some_func($loop_value['foo']);
$loop_value['bar'] =3D some_other_func($loop_value['bar'], true);

References are fiddly, but they do have their uses=2E Short of eliminating=
 mutability, per functional programming, I think they'll always have their =
place, in some form=2E

Regards,

--=20
Rowan Collins
[IMSoP]