Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:99327
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.214.54 as permitted sender)
MIME-Version: 1.0
Sender: morrison.levi@gmail.com
In-Reply-To: <CAEUnE0evXQYN_pAS-HPEGM-BT-DcK=VT0WyYPAVeHyXfpMY7sg@mail.gmail.com>
References: <CAB8JV1Pub_6ppV_2Nub90z0kpfKZikmxvg-aUUB6SQHSqC34vQ@mail.gmail.com>
 <CA+kxMuQr0iu52yXsgUk82CTN-3h4NfJx+3xC3FREUTaYFiKZ1g@mail.gmail.com>
 <CAB8JV1NWbotD-pWOptY7TX4rMWWzaH9x8Z1Ztfumb7Q4bFeWUg@mail.gmail.com>
 <1496415412.4363.66.camel@schlueters.de> <CAEUnE0evXQYN_pAS-HPEGM-BT-DcK=VT0WyYPAVeHyXfpMY7sg@mail.gmail.com>
Date: Fri, 2 Jun 2017 11:21:34 -0600
Message-ID: <CAFMT4NqqRcAKg0rcwgGRiY_uvwPt=D3VU_2WSUN-H00kgh6-qw@mail.gmail.com>
To: Michael Morris <tendoaki@gmail.com>
Cc: "internals@lists.php.net" <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [PHP-DEV] RFC proposal
From: levim@php.net (Levi Morrison)

On Fri, Jun 2, 2017 at 11:12 AM, Michael Morris <tendoaki@gmail.com> wrote:
> What about foreach by reference, which is honestly the only time I use
> referencing anymore...
>
> foreach ($array as $key => &$value) {
>   $value = someOp($value);
> }
>
> Is this also bad?

I'm not going to say "bad" but I would not personally write it that
way. If the memory cost is too high to duplicate then I'd use a
generator that maps the value; I have this function in all my projects
because it's fairly common anyway:

    function (callable $fn, iterable $input) {
        foreach ($input as $key => $value) {
            yield $iey => $fn($value);
        }
    }