Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:99248 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 83504 invoked from network); 30 May 2017 01:10:33 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 30 May 2017 01:10:33 -0000 Authentication-Results: pb1.pair.com header.from=php@golemon.com; sender-id=softfail Authentication-Results: pb1.pair.com smtp.mail=php@golemon.com; spf=softfail; sender-id=softfail Received-SPF: softfail (pb1.pair.com: domain golemon.com does not designate 74.125.82.45 as permitted sender) X-PHP-List-Original-Sender: php@golemon.com X-Host-Fingerprint: 74.125.82.45 mail-wm0-f45.google.com Received: from [74.125.82.45] ([74.125.82.45:38851] helo=mail-wm0-f45.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id FB/9A-34073-786CC295 for ; Mon, 29 May 2017 21:10:32 -0400 Received: by mail-wm0-f45.google.com with SMTP id e127so78915226wmg.1 for ; Mon, 29 May 2017 18:10:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=golemon-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=MzmJAsCwjOiLifqOS/eSHq2+sSVIeq3t4pBs6335m4A=; b=01/qNM10oMOL01D79oZC9Zc7/1srakSICcJZ9fRuAiVjsNnUkmiwCkh88XKOJmT5Ad FvVuLNmWh0i0/oV3WXuLKKpn/F8MCnLPkBv+OXDsTfvbkYMogAv0RHE66c9P0+znLiT1 vP1x+5+fREaoGhueZKeqkU2DetNk4ldKuYd4dM2qHBFlqHxJhzcgrmNgbsozsI6YPHUg rGHrMoxv/Zm1bSiXXE5qyvh1GeFUHQM/prn+2vhVUlU/5tbKkFj+IYKqEZAwpvRtcPvA xp80Rm61D+O2xftUsm7jay9uVZRWWuXK9+cyskKNerPCAthq00Ryld/d0JyjSefma1Qy nfQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=MzmJAsCwjOiLifqOS/eSHq2+sSVIeq3t4pBs6335m4A=; b=j1xViDYwjXoXW5GQgtr7iOQIHeyGm4LygYgfhSxfvInIPh6oJJaUR51Onpz5Vo3a17 7lnSfQ3VYtF5B5Cnc6A4kjtzxeKomXv9ZquASqA7CBpc2mQ7aH91mY/QFg2gBOXk3pO1 1otmzmKN/gHlFwv3lwoCFo4jAJjx+59L8ZThCrJLNo1loMtyO/KiglVZ09kjwjP+PFI/ xumsgwGy8L1FLb5yPPC8kCWo9nwU9s1Rs5yq7YgTdzTEvNWgmgpJd4ALM71gblz6dEGX 7yfVv4VdnrQlfY/Ks6eeh0d5l+zjOhXRygnIJXVqgt4hYVf1MudfHkc3vo4lbdYEs8Yh jJ8w== X-Gm-Message-State: AODbwcBYvTu0R40kq5sAbGun1UXF28QXYNGf2FOZ1AYeprR+Wu5r5mkh CZmnJ9QTP+U/vI0cg8JwPwDqeSigm6U7 X-Received: by 10.28.51.73 with SMTP id z70mr11113291wmz.65.1496106628792; Mon, 29 May 2017 18:10:28 -0700 (PDT) MIME-Version: 1.0 Sender: php@golemon.com Received: by 10.223.157.38 with HTTP; Mon, 29 May 2017 18:10:28 -0700 (PDT) X-Originating-IP: [2604:2000:dd18:cb00:1d35:5fc6:37be:7398] In-Reply-To: <45056683-ffba-c510-cb64-36abcbd60502@gmail.com> References: <1495067758.9756.47.camel@schlueters.de> <1495103485.9756.58.camel@schlueters.de> <6F.B1.10292.2B026295@pb1.pair.com> <45056683-ffba-c510-cb64-36abcbd60502@gmail.com> Date: Mon, 29 May 2017 21:10:28 -0400 X-Google-Sender-Auth: Ej9iU3vnYFP0Cae6lXXzjq8k8UY Message-ID: To: Stanislav Malyshev Cc: Andrea Faulds , PHP internals Content-Type: text/plain; charset="UTF-8" Subject: Re: [PHP-DEV] Implement formal process for run-tests.php refactor From: pollita@php.net (Sara Golemon) On Mon, May 29, 2017 at 8:20 PM, Stanislav Malyshev wrote: >> Is that worth a shot, do you think? > > Definitely. There's no reason also why it shouldn't work so failing > tests in such scenario probably should be treated as bugs. > > A lot of tests also inherently parallel-safe - probably majority of > them, though wouldn't claim I am 100% sure - so maybe marking them as > such is also not bad. > HHVM imported PHP's core test suite and its test running *is* parallelized. We ran into a number of tests which aren't parallel friendly (shared, hard-coded port number and/or tempfile path) and I upstreamed fixed for all the tests we had issue with, so the state of PHP's tests *now* should be pretty good. (Of the extensions HHVM actually has in common, anyway). There are a handful of cases where some tests simply expect to be run in order, and we flagged these using a marker file: testname.php.serial (See: https://gist.github.com/sgolemon/429e4deb413eb539d653460ae062c228 ) -Sara