Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:99224
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain devilix.net designates 209.85.218.41 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <10E6F2E5-45E6-4D20-9DDD-F8C1632A8CA4@koalephant.com>
References: <CA+kxMuT+MBX1e71y9i3Kfn0cCAWG8+iPW=TY1VA532q6Jkg=LA@mail.gmail.com>
 <10E6F2E5-45E6-4D20-9DDD-F8C1632A8CA4@koalephant.com>
Date: Mon, 29 May 2017 12:48:17 +0300
Message-ID: <CAPhkiZyaSWdzx_7rPun+cj1ARhQ5aV4EqXzuynPpY7gQchB6WQ@mail.gmail.com>
To: Stephen Reay <php-lists@koalephant.com>
Cc: Dan Ackroyd <danack@basereality.com>, 
	"internals@lists.php.net" <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] [RFC][Discussion] Consistent callables
From: narf@devilix.net (Andrey Andreev)

Hi,

On Mon, May 29, 2017 at 12:28 PM, Stephen Reay <php-lists@koalephant.com> w=
rote:
>
> Regarding the big change you suggest, making protected/private methods re=
turn false unless a new third parameter is true in is_callable():
>
> I think you need to make your intention a *lot* clearer under the "Privat=
e and protected functions no longer report as callable for is_callable=E2=
=80=9D section. You make no mention of it being user controlled, simply =E2=
=80=9Cthis will not work any more=E2=80=9D, until the next section.
>

I too noticed this, and the RFC content can be improved in general to
be more easily understandable.

But that being said, I wholeheartedly agree with the entire proposal.

Cheers,
Andrey.