Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:99204
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain basereality.com from 209.85.192.180 cause and error)
MIME-Version: 1.0
In-Reply-To: <35177214-db24-5bc8-2020-37b2951259a2@rhsoft.net>
References: <CADqTB_jB2ic4jx84HXVBPDr2qbP-DnXe782quKwc6o-ERpJJVw@mail.gmail.com>
 <269187f4-5924-a7cc-9163-40134546451f@fleshgrinder.com> <CAPhkiZyX1zC3W03CS6KBSgQxoWht96oOeFrAswG2jrSM2zJEPw@mail.gmail.com>
 <CA+kxMuQ5exWsJanp88bz7zTmoqtmKQ66NydqPhUgd=mPywncmA@mail.gmail.com>
 <CAPhkiZwi-Ji2LVFk46MpwHWmPxC_sBZkTiAHMZOV7qNiku9aug@mail.gmail.com>
 <CANUQDCiMfhUAeAX+3yfSkSp1vodegvVDt=ff7AWYPia_AnxQ4A@mail.gmail.com>
 <2dca6983-bbde-6042-6608-a593df2e85ed@gmx.de> <35177214-db24-5bc8-2020-37b2951259a2@rhsoft.net>
Date: Fri, 26 May 2017 15:26:22 +0100
Message-ID: <CA+kxMuRn08VyRZ7zTScDchDrnQc3D+d_zvs-qj6Ep=u+pVifOw@mail.gmail.com>
To: "lists@rhsoft.net" <lists@rhsoft.net>
Cc: "internals@lists.php.net" <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [PHP-DEV] Parameter type widening RFC
From: danack@basereality.com (Dan Ackroyd)

On 26 May 2017 at 13:23, lists@rhsoft.net <lists@rhsoft.net> wrote:
> does that also fix the issue https://bugs.php.net/bug.php?id=74394


Dear Anonymous,

That "issue" is actually 3 issues.

case 1

class A {
  public function test($a) {}
}
class B extends A {
  public function test(string $a) { }
}

This breaks LSP - because B::test doesn't accept all the things that
A::test can accept and so is unlikely to ever be supported.


case 2

class A {
  public function test($a) {}
}

class B extends A {
  public function test($a): string {}
}

This works since return types were introduced.

case 3

class A {
 public function test($a): string { }
}

class B extends A {
 public function test($a) {}
}

This breaks LSP - anything that is calling A::test would only expect a
string to be returned, but B::test can return anything so is unlikely
to ever be supported.

btw I assume that lists@rhsoft.net and spam2 at rhsoft dot net are the
same anonymous person. Quoting some of your words:

spam2 at rhsoft dot net
>
> maybe you guys also don't see the possibility of shared-libraries used by hundrets of
> applications by just use "include_path" when you talk about "deplyoment" and "2017"....
>
> that is not possible with a stupid fatal error

lists@rhsoft.net wrote:
>
> frankly get out of my sight with composer
>
> i maintain the whole webstacke for many years at my own (rpm packages) and so the Fedora > repos have excluded anything relevant to PHP - trying to build composer by just download > the src.rpm ends in a ton of build dependencies
>
> we maintain a large codebase (250000 LOC) over 15 years

Your tone of words is quite rude and dismissive of other people both
on this list and in the bug reports. That's really not a good way to
persuade people, but particularly so when you seem to not understand
subtle computer science principles but instead want PHP to be
customised for your own way of working.

If you're installing Composer through an RPM and it's requiring you to
install lots of dependencies, something has gone horribly wrong.
Composer is a standalone phar executable which just needs a normal PHP
environment.

I'd strongly recommend having another go at using it, and in general
opening yourself up to new ways of doing things rather than being rude
to people who don't share your way of working.

cheers
Dan