Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:99160
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain benramsey.com from 209.85.220.176 cause and error)
MIME-Version: 1.0
In-Reply-To: <CADyq6sLvmYS0oqhSTzq13V-9604WSOdqmaeM5yVGhgQGKpjjxQ@mail.gmail.com>
References: <e71637c6-db4a-7f29-ae08-89625eae8b53@fleshgrinder.com>
 <CA+kxMuTV7p14HbDpEQrwJKG3soUgxXV5BEs6WHgPtSOmjc2grQ@mail.gmail.com>
 <f9c91d81-097b-680e-904a-126ffee16b19@rhsoft.net> <ba50cf2d-6744-e78f-18be-e1d65990f0d9@garfieldtech.com>
 <CAFMT4NpNmkpfcWXsMydxDbULV9iNTe9BJxYdFdHdD1H36P1p6w@mail.gmail.com>
 <be5db50a-bc70-2cfe-5a0a-dc0ef15360ba@fleshgrinder.com> <CADyq6sKta5ngCkQc3tZZ5Pw3GqW93Lk283ofeuPMf6c7fjyCLg@mail.gmail.com>
 <e47a2c34-b6f3-66de-1f03-6753d5b1d4ea@fleshgrinder.com> <CADyq6sLvmYS0oqhSTzq13V-9604WSOdqmaeM5yVGhgQGKpjjxQ@mail.gmail.com>
Date: Wed, 24 May 2017 16:12:06 -0400
Message-ID: <CAJOjSBi0ZrmXoDWv4iMTgXCLc74QuCWfbjK4CMbhCSPx5YC7LA@mail.gmail.com>
To: Marco Pivetta <ocramius@gmail.com>
Cc: Fleshgrinder <php@fleshgrinder.com>, php-internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [PHP-DEV] [RFC] [Discussion] UUID
From: ben@benramsey.com (Ben Ramsey)

On Wed, May 24, 2017 at 2:47 PM, Marco Pivetta <ocramius@gmail.com> wrote:
>
> On Wed, May 24, 2017 at 8:39 PM, Fleshgrinder <php@fleshgrinder.com> wrote:
> >
> > Furthermore, I carefully crafted everything to be as close to userland
> > as possible. No magic, none at all. I use default PHP built-in stuff for
> > everything. Even the parameter parsing is 1:1 as it would be if you
> > would define the very same class in PHP.
> >
> > I will extend my signature with "No Magic!" now. ;)
> >
>
> Perfect, this absolutely makes it a huge :+1: on my side.
>
> Last thing I'd suggest is to grab Ben Ramsey and get him to check the patch
> :-)
>

I'll take a look at the patch soon. If this is accepted to the core,
I'll probably add an adapter to ramsey/uuid that wraps this
implementation. The point of the "over engineering" there is to provide
choice. Some users want to generate bytes from sources other than
random_bytes() (i.e., libsodium) or encode UUIDs in different ways
(i.e., ordered time). A UUID generator in the core will only help to
improve ramsey/uuid, providing more choice and better performance.

I may split out the less-used adapters and codecs into separate
components in version 4 or 5 of ramsey/uuid, though, since most users
don't need anything other than the default.

-Ben