Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:99100
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.128.182 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <1495067758.9756.47.camel@schlueters.de>
References: <CALYT1Yrs-9Xr0tyGGWdVBsm0r6h+w+GZcLT0UbVCSMrBYZ01bQ@mail.gmail.com>
 <b62db45d-6b77-f5ec-ac0f-096687d3efe7@fleshgrinder.com> <CADyq6s+=DCk1LiBc3wjUBRdf-mnkgQEqRmGoUeLc+XEjqjk6Qg@mail.gmail.com>
 <1495067758.9756.47.camel@schlueters.de>
Date: Thu, 18 May 2017 12:08:05 +0200
Message-ID: <CADyq6sKVSgry1AwsqL2EBr96ot35Hoy37pB4ri4wEZeaAWEwiQ@mail.gmail.com>
To: =?UTF-8?Q?Johannes_Schl=C3=BCter?= <johannes@schlueters.de>
Cc: PHP Internals List <internals@lists.php.net>, Sammy Kaye Powers <me@sammyk.me>
Content-Type: multipart/alternative; boundary="94eb2c1cc54cf3bdd1054fc995d5"
Subject: Re: [PHP-DEV] Implement formal process for run-tests.php refactor
From: ocramius@gmail.com (Marco Pivetta)

--94eb2c1cc54cf3bdd1054fc995d5
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, May 18, 2017 at 2:35 AM, Johannes Schl=C3=BCter <johannes@schlueter=
s.de>
wrote:

> On Mi, 2017-05-17 at 23:30 +0200, Marco Pivetta wrote:
> > Is Sebastian copied in here? Why can't we just use the super-battle-
> > tested
> > PHPUnit? It supports phpt and a ton of plugins, plus everyone uses it
> > and
> > is familiar with it.
>
> PHPUnit is huge. run-tests is a small script in a single file which I
> can quickly edit. For PHPUnit I have multiple files and need tooling to
> phar them up.
>

You don't need to phar them up - just run a typical composer installation,
like everyone else, and like every PHP package running CI on
travis-ci/circle-ci/continuous-php ever built in the last 5 years.
At this point, composer and phpunit are such big players that breaking them
or breaking PHP makes no difference at all for the user-base.


> PHPUnit (according to it's website) also has more dependencies (DOM and
> JSON) which are not included in --disable-all. used
>

Ah yes, that is indeed a problem. I think these deps are used in some
assertions only, so it may be possible to drop them if the assertions are
segregated somewhere else.

I'm not sure if PHPUnit meanwhile supports redirect tests as in PDO.
>

Unsure - got a link to those?


> Is there a performance comparison? - make test runs for a loooong time.
> A difference might have an impact. (both ways round ;) )
>

PHPUnit has plugins to parallelize and aggregate results too - the point of
using a battle-tested and commonly used solution is precisely the benefits
you get from community support.

Marco Pivetta

http://twitter.com/Ocramius

http://ocramius.github.com/

--94eb2c1cc54cf3bdd1054fc995d5--