Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:99093
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain marcodor.com designates 93.115.138.71 as permitted sender)
To: "'Matteo Beccati'" <php@beccati.com>,
	<internals@lists.php.net>
References: <002801d2cd97$63921700$2ab64500$@marcodor.com> <a5702a56-3a77-6453-f649-5b3b5fceb5a6@beccati.com>
In-Reply-To: <a5702a56-3a77-6453-f649-5b3b5fceb5a6@beccati.com>
Date: Thu, 18 May 2017 11:06:17 +0300
Organization: Marcodor
Message-ID: <000901d2cfad$a0349c60$e09dd520$@marcodor.com>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQGmIHpy4RzO8NFDYRluODon0aGvPAIf47PzokIVmoA=
Content-Language: ro
Subject: RE: [PHP-DEV] PDO Parameter types // PDO::PARAM_AUTO
From: dorin.marcoci@marcodor.com ("Dorin Marcoci")

Hello Matteo,

-----Original Message-----
From: Matteo Beccati [mailto:php@beccati.com]=20
Sent: Thursday, May 18, 2017 8:13 AM

>> But when implementing FB Boolean data type parameters and doing=20
>> ->bindValue ('bool_param', false) I get an empty string internally.
>>=20
>> Yes, true ZVAL is converted as string as '1', but false as an empty=20
>> string, not so consistent here ;)

>That's not true.

>$p =3D new PDO("pgsql:dbname=3Dpostgres");
>$p->prepare("SELECT ?::bool");
>$s->bindValue(1, false);
>$s->execute();
>var_dump($s->fetchColumn());'

>outputs:
>bool(false)

>What are you referring to?

I wrote "internally", meaning in C driver code, not in PHP.
When a bool ZVAL variable is converted to a string ZVAL.
Your example is irrelevant.


>> That's why I think, it will be great to have a special type like=20
>> PDO::PARAM_AUTO and a config flag to set it as default instead of =
PARAM_STR.

>Config flags are evil as it's one more thing you'd need to be aware of =
and could change depending on the environment you run your script or =
library on.

Maybe I was not so explicit, I meant an option flag in PDO constructor =
in order to not break existing code, not a hardcoded global config in =
php.ini
Here: public PDO::__construct ( string $dsn [, string $username [, =
string $password [, array $options ]]] )
something like PDO::PARAM_AUTO =3D> true or "server param data types", =
we should think for a good name.

But I'm with all hands up for making PDO::PARAM_AUTO default in =
bindValue, just it may require some small adjustments in all PDO =
drivers.
If server type params are not supported, treat them as strings. So it =
should work.


-
  D.