Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:99091
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain beccati.com designates 176.9.123.236 as permitted sender)
To: Adam Baratz <adam.baratz@gmail.com>,
 "internals@lists.php.net" <internals@lists.php.net>
References: <CADxrgCMNFqLAoMCbssqkajgn9=_7HTbk70LybwpD+Co3aQzmJg@mail.gmail.com>
Message-ID: <94cdf88b-9933-a72d-d351-546da495d4ab@beccati.com>
Date: Thu, 18 May 2017 07:21:13 +0200
MIME-Version: 1.0
In-Reply-To: <CADxrgCMNFqLAoMCbssqkajgn9=_7HTbk70LybwpD+Co3aQzmJg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] [RFC] deprecate PDO::PARAM_NULL
From: php@beccati.com (Matteo Beccati)

Hi Adam,

On 15/05/2017 13:49, Adam Baratz wrote:
> I've heard a few people here mention that this type isn't useful. It looks
> like it wouldn't be harmful to remove. The RFC mainly outlines the impact
> and proposes a schedule for doing so.
> 
> https://wiki.php.net/rfc/deprecate_pdo_null
> 
> Please let me know your thoughts.

Please elaborate:

"A handful of people on the internals mail list have asked for it to be
removed" - where and when?

"Supporting it adds some weight to PDO" what kind of weight? How many
lines / microseconds are we going to save?

I would agree that NULL is not a type and the constant shouldn't have
been there in the first place, but I think it could be a bit too late now.

The proposal itself is rather evil: it would break lots of code (a quick
github search shows 95k+ results) for basically no gain. Or maybe I just
didn't get it.


Cheers
-- 
Matteo Beccati

Development & Consulting - http://www.beccati.com/