Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:99077
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain heigl.org designates 195.191.240.18 as permitted sender)
Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (1.0)
In-Reply-To: <CALYT1Yrs-9Xr0tyGGWdVBsm0r6h+w+GZcLT0UbVCSMrBYZ01bQ@mail.gmail.com>
Date: Wed, 17 May 2017 17:00:23 +0200
Cc: PHP Internals <internals@lists.php.net>
Content-Transfer-Encoding: quoted-printable
Message-ID: <B94FC80C-5DD6-4326-B826-8D0B40B37A84@heigl.org>
References: <CALYT1Yrs-9Xr0tyGGWdVBsm0r6h+w+GZcLT0UbVCSMrBYZ01bQ@mail.gmail.com>
To: Sammy Kaye Powers <me@sammyk.me>
Subject: Re: [PHP-DEV] Implement formal process for run-tests.php refactor
From: andreas@heigl.org (Andreas Heigl)





--=20
Andreas Heigl
Andreas@heigl.org
> Am 17.05.2017 um 16:28 schrieb Sammy Kaye Powers <me@sammyk.me>:
>=20
> Hello internals folks!
>=20
> As you may already know, run-tests.php is an old legacy app that is in
> serious need of a refactor. Some things that are badly needed amongst othe=
r
> things are:
>=20
> - Better maintainability
> - Unit tests
> - Concurrency
> - Prettier output
>=20
> I have seen numerous attempts of rewriting run-tests from scratch after
> some rallying at a UG or PHP conference only to see the initial excitement=

> die off. The general advice for refactoring legacy apps is to not start
> with a clean slate, rather refactor a little bit at a time. We should trea=
t
> run-tests as we would any other legacy app.
>=20
> We need a structured process to allow the run-tests app to get refactored a=

> little bit at a time. I propose the following (open to discussion of
> course).
>=20
> 1) Create a new run-tests karma with access to php-src.git/run-tests.php
> (and hopefully the soon-to-be created php-src.git/run-tests folder).

Just a stupid question for a non-regular: Why not a separate repo? In the en=
d run-tests.php is a PHP-application and not a C one and with tests and all s=
uch things to do it might be wasier to develop independent from the PHP-sour=
ces.=20

It needs to be available to the PHP-sources in the end, but that might be po=
ssible by using git-submodules (or downloading a phar-file?)

Just my 0.02=E2=82=AC

Cheers=20

Andreas
>=20
> 2) Elect 2-3 people and grant the new run-tests karma to them. They will
> champion the PR's that incrementally improve run-tests.
>=20
> 3) The new run-tests champions (we'll call them "champions" because, why
> not?) will run the entire test suite ensuring that the refactor didn't
> inadvertently break the functionality and if all good, merge. (We might be=

> able to get a solid Docker container or an automated CI process for an
> end-to-end test - thoughts?)
>=20
> 4) The run-tests champions could be elected for a year-long term with the
> possibility of being reelected for another year commitment. This would hel=
p
> prevent run-test champion drop-off (because sometimes, life happens).
>=20
> Once we get a process in place, I've drafted up a possible proposal of nex=
t
> steps to get run-tests refactoring kicked off:
>=20
> https://github.com/SammyK/run-tests#proposed-refactoring-path
>=20
> It's time to circle the wagons on run-tests! :)
>=20
> Thanks,
> Sammy Kaye Powers
> sammyk.me
>=20
> 230 S Clark St #194
> Chicago, IL 60604