Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:99051
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain fedoraproject.org from 217.70.183.201 cause and error)
To: internals@lists.php.net
References: <CAOWwgpm3Sq0nLeVcgXdGAjtcaQGuLgK=oTJRWFvQay4dDUWiXw@mail.gmail.com>
Message-ID: <1822acea-b6df-35bf-c760-7d1d06a3d88f@fedoraproject.org>
Date: Mon, 15 May 2017 17:49:02 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.1.0
MIME-Version: 1.0
In-Reply-To: <CAOWwgpm3Sq0nLeVcgXdGAjtcaQGuLgK=oTJRWFvQay4dDUWiXw@mail.gmail.com>
Content-Type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature";
 boundary="S4ijGTjOtKAUo0XT8lbrodErwcsgf948G"
Subject: Re: [PHP-DEV] BC break in master (7.2) - Distinguish between
 unmatched subpatterns and empty matches in preg_*()
From: remi@fedoraproject.org (Remi Collet)

--S4ijGTjOtKAUo0XT8lbrodErwcsgf948G
Content-Type: multipart/mixed; boundary="MnWtuagqJwE8JjIT6nBDt29UUvcxhPSFH";
 protected-headers="v1"
From: Remi Collet <remi@fedoraproject.org>
To: internals@lists.php.net
Message-ID: <1822acea-b6df-35bf-c760-7d1d06a3d88f@fedoraproject.org>
Subject: Re: [PHP-DEV] BC break in master (7.2) - Distinguish between
 unmatched subpatterns and empty matches in preg_*()
References: <CAOWwgpm3Sq0nLeVcgXdGAjtcaQGuLgK=oTJRWFvQay4dDUWiXw@mail.gmail.com>
In-Reply-To: <CAOWwgpm3Sq0nLeVcgXdGAjtcaQGuLgK=oTJRWFvQay4dDUWiXw@mail.gmail.com>

--MnWtuagqJwE8JjIT6nBDt29UUvcxhPSFH
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable

Le 15/05/2017 =C3=A0 08:57, Nicolas Grekas a =C3=A9crit :
> Hi,
>=20
> in master, feature request https://bugs.php.net/61780 has been implemen=
ted
> and merged into master thanks to https://github.com/php/php-src/pull/13=
03

I think everyone agree that BC should be avoid, when possible.

Even if this one is quite small, and have been tried to be as small as
possible, it exists.

Dev time are designed to detect such issues as soon as possible,
so first, thanks for reporting.

IMHO, I think a new flag to enable the new feature seems the nicest way
to keep BC and offer the new feature/behavior.

> I'm not against reverting the commit,

Reverting the commit, will be a pity

> I suggest not to set unmatched subpatterns at all,

Can you give an example of expected output ?
(I think stable position for matched pattern is important)

php -r 'var_dump(preg_match("/(a)?([a-z]*)(\d*)/", "123", $matches),
$matches);'




Remi.


--MnWtuagqJwE8JjIT6nBDt29UUvcxhPSFH--

--S4ijGTjOtKAUo0XT8lbrodErwcsgf948G
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iEYEARECAAYFAlkZze4ACgkQYUppBSnxahgvMQCg9ikjY5JW+yDlR+H58H7jkL1A
KUIAn1Twe+8MULFP8qppi6zLG5Db+Fh1
=WZzj
-----END PGP SIGNATURE-----

--S4ijGTjOtKAUo0XT8lbrodErwcsgf948G--