Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:99037 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 22756 invoked from network); 15 May 2017 10:01:41 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 15 May 2017 10:01:41 -0000 Authentication-Results: pb1.pair.com smtp.mail=php@beccati.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=php@beccati.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain beccati.com designates 176.9.123.236 as permitted sender) X-PHP-List-Original-Sender: php@beccati.com X-Host-Fingerprint: 176.9.123.236 box.beccati.com Received: from [176.9.123.236] ([176.9.123.236:38312] helo=box.beccati.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id E1/67-15531-38C79195 for ; Mon, 15 May 2017 06:01:40 -0400 Received: from authenticated-user (box.beccati.com [176.9.123.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by box.beccati.com (Postfix) with ESMTPSA id D75B72002D4; Mon, 15 May 2017 12:01:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=beccati.com; s=mail; t=1494842496; bh=ZKE8t6XGy4Ct4PeVD6xriO/n7Fl6h426gan9eQ3w7Bo=; h=Subject:To:References:From:Date:In-Reply-To:From; b=mIdVRwhIjxajO3nq5oHlRsXnuSw/prNi4ygHs39PhQdtj2/UudZPHFldtnPTVtZTG MQ1///GK16hHOrNa8tMWO//OdpyBu33eu0UPWapstpvS4Un3FLcNRVgSzRWdFbqvSt hQslYC6TMQiij+7X+4vCNGHIEZJBOZLxmg1HzoSPZbAhtYF9oKuRNtNdmOEbHg9h2b QnHLUZSqfIplBHkUXtvSTt7DKabMBch+B4vc7K1rMAYYbMbm1qUbjNcIEBEFkQSh2a 2tc3LXEEttJEezMR/SiIhcdsG+xiro3W74Igb4ImcfOngi1wDWIQEe/YAujkjaonPw 1feZ2SIn2dMMA== To: Adam Baratz , "internals@lists.php.net" References: Message-ID: Date: Mon, 15 May 2017 12:01:35 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] Re: [VOTE] PDO Float Type From: php@beccati.com (Matteo Beccati) Hi Adam, On 15/05/2017 09:47, Adam Baratz wrote: > I had a request on the PR[1] to rename the const, from PDO::PARAM_FLT to > PDO::PARAM_FLOAT. Agree that readability is better here. Since there's been > a change, I'll plan on opening the vote tomorrow. Are you kidding me? You can't possibly think that changing the constant name resets the cooldown counter. You also said: > Based on previous feedback, I thought the new version was materially > different. But if a handful of voters from the last round respond and say > that these changes won't change their vote, then sure, there's no point in > rerunning this. You can count Marco and myself as a handful. I see no one else active on internals saying "yes please". You insist this change will make wonders but it doesn't. MS SQL apparently can't use indexes if you pass the float as strings, while most other databses have evolved since the 2000s and now can. You could quite easily work around it by embedding your floats in the SQL command string instead. Which is basically what emulated prepares would do for you. On the other hand I am still convinced that the new type could potentially cause more issues for anyone else not using pdo_dblib. Cheers -- Matteo Beccati Development & Consulting - http://www.beccati.com/