Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:99033 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 7147 invoked from network); 15 May 2017 06:57:26 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 15 May 2017 06:57:26 -0000 Authentication-Results: pb1.pair.com header.from=nicolas.grekas@gmail.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=nicolas.grekas@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.214.53 as permitted sender) X-PHP-List-Original-Sender: nicolas.grekas@gmail.com X-Host-Fingerprint: 209.85.214.53 mail-it0-f53.google.com Received: from [209.85.214.53] ([209.85.214.53:37083] helo=mail-it0-f53.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id DA/45-15531-45159195 for ; Mon, 15 May 2017 02:57:26 -0400 Received: by mail-it0-f53.google.com with SMTP id g126so63310977ith.0 for ; Sun, 14 May 2017 23:57:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=sj1r0kSODFeYDb31hbY2J4pqX/WNS6IM4fwpiZR+1A8=; b=o7ia6FspHBKJq5UunSThBOyauv/Bg3pQUQwo/u81pqrfW0qPKFcBlEHBNqojrceLpo MH8MmJvrge/rF1FHBV28/mYK9gfPSSza1kpEm1+YFnzLTv+qawHmj8ndcO5GZvBlzJVl mSLPVZ/rCn+fQ/6qCrnijIT5wMJJY5C12i5+yzgf7qtbFtCbf9R6lAwEWEwgmfeBNLzg 3dOqqr4O7JVCLwOd9Y/rOh9w7FuO+K9rWk9iFfwI+H7D71oAsJenMcloGVdkRwtfDZ4A nyPvZTLV3g2duKP9KS7TftPr4Mmw6ur2rxG7syHFou7NXBeHMIb7KpgaPDj8hP4u+Ssh wFeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=sj1r0kSODFeYDb31hbY2J4pqX/WNS6IM4fwpiZR+1A8=; b=speCKiD83FR8MGcWieBYADS2ROnmf0Xdij7gZBNub0kR/d8nfAcE9hA44qwqEzAQJP 0M4yUEN4aa7nIoHC65iLJ/kK3Kuj7mc3PZrS+6/6z6wJhBJSIaK7saMZ/28RHOyIBI4M /o5zS6h+p0FyEVb7oF6BAofX+6i02APl7gyAmld3IxFB5xJ7PdU82zbMOGXetGA728Ko POHTZtVk7P1e0DafUyM1CxK1lSGPXEEYIQxamhfofSeS6LpM0aD0KTpDhVKPL+svy6mX jGMvkDZ2BUA0XgK2+/VE4VljRvyinWfD4ThKbc2lDbz8pgWjG0E9P+UYLVAfA75nz/qC VGKA== X-Gm-Message-State: AODbwcADLW2/C8fRVFdALVQ6pel2YcwT/lo0kJGkzoKFwi/x14ILY00V +LW+qOkJugZQnLv+6ecp2gMoTtg6P/JH X-Received: by 10.36.91.130 with SMTP id g124mr3977128itb.119.1494831441959; Sun, 14 May 2017 23:57:21 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.130.201 with HTTP; Sun, 14 May 2017 23:57:01 -0700 (PDT) Date: Mon, 15 May 2017 08:57:01 +0200 Message-ID: To: "internals@lists.php.net" Content-Type: multipart/alternative; boundary="001a114490e618e4f8054f8a915c" Subject: BC break in master (7.2) - Distinguish between unmatched subpatterns and empty matches in preg_*() From: nicolas.grekas@gmail.com (Nicolas Grekas) --001a114490e618e4f8054f8a915c Content-Type: text/plain; charset="UTF-8" Hi, in master, feature request https://bugs.php.net/61780 has been implemented and merged into master thanks to https://github.com/php/php-src/pull/1303 But as noted in the PR and even in the UPGRADING file, this is a BC break: . preg_match() and other PCRE functions now distinguish between unmatched subpatterns and empty matches by reporting NULL and "" (empty string), respectively. Formerly, either was reported as empty string. While trying to run Symfony's test suite against 7.2, we noticed that this BC break is hitting several components badly. If Symfony is hit, there will be many more userland code impacted for sure. As written explicitly in the releasing policy of php-src, BC breaks must not happen in minor versions. Therefore, I'm kindly but strongly asking for this BC break to be reconsidered and removed. Thanks for your consideration, Nicolas --001a114490e618e4f8054f8a915c--