Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:98988
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.220.169 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CADyq6sKfEUT2eGPeGzWJoWnFJV6b9kC9WnavFk4xGAyZb1_byw@mail.gmail.com>
References: <CADxrgCOpfchXaCKhT_Z1acUZnNmiE1eZ7ZA0JHrTUycHGyKKgA@mail.gmail.com>
 <CADxrgCPAzk6wSfLzRrjBOP7Fyc=GepZde6Z8Vp91UcMbRMiU7w@mail.gmail.com>
 <CADxrgCOb1e7NSNNXYeSWCjPxwkZsVAi77eN6zWSYTw_MrNJb-A@mail.gmail.com>
 <CADxrgCOaRQVkbfgdGEqBSEirvwGywi8g5=4QyN1FapzfEH+XtA@mail.gmail.com> <CADyq6sKfEUT2eGPeGzWJoWnFJV6b9kC9WnavFk4xGAyZb1_byw@mail.gmail.com>
Date: Tue, 9 May 2017 14:01:59 -0400
Message-ID: <CADxrgCONkBhfcpzG8iBKYZEEJxcbND7Y3HmjtGf3BTK9dsrmMA@mail.gmail.com>
To: Marco Pivetta <ocramius@gmail.com>
Cc: "internals@lists.php.net" <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=94eb2c07cd46f56afe054f1b261a
Subject: Re: [PHP-DEV] Re: [VOTE] PDO Float Type
From: adambaratz@php.net (Adam Baratz)

--94eb2c07cd46f56afe054f1b261a
Content-Type: text/plain; charset=UTF-8

Hi,

Thanks for the feedback.

I voted "no" because for very little improvement (which really isn't worth
> it)
>

It would help me to understand why you think this. It's difficult to
generate queries with the best execution plans if the type information
isn't good. Floating point values are part of SQL. Is your thought that
they aren't used enough, that this implementation is missing something, or
something else?

 * users foot-gunning themselves due to misuse of float values (yes, they
> will put floats where real is needed)
>

Did you see the latest rev of the RFC? It should address this point. If you
pass a string and label it PDO::PARAM_FLT, only emulated prepares and
pdo_sqlite will cast it to a float. And that's only for consistency with
how they handle other types. Does that make you more comfortable? Or is
there another use case you're concerned about?

That said, see https://wiki.php.net/rfc/voting#resurrecting_rejected_propos
> als about resurrecting the vote: it will need to wait a few months.
>

Based on previous feedback, I thought the new version was materially
different. But if a handful of voters from the last round respond and say
that these changes won't change their vote, then sure, there's no point in
rerunning this.

Thanks,
Adam

--94eb2c07cd46f56afe054f1b261a--