Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:98927
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.83.52 as permitted sender)
MIME-Version: 1.0
Date: Tue, 2 May 2017 02:01:42 -0700
Message-ID: <CAMbn9ZHzG1W_7r=UjLPTsva6Wgc32ext8ijUMfW_bJ0unC2i+Q@mail.gmail.com>
To: PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a11461ea8dc043c054e86c97c
Subject: variables_order issue with run-test.php
From: themattficken@gmail.com (Matt Ficken)

--001a11461ea8dc043c054e86c97c
Content-Type: text/plain; charset=UTF-8

Hi,

I noticed that php.ini-development now sets variables_order="GPCS" instead
of "EGPCS".

run-test.php uses $_ENV to read environment variables and will set those on
all the child processes it creates. However, if variables_order="GPCS",
$_ENV will be empty and the environment variables table on the child
process will be empty, at least on Windows, the only env variables the
child then gets are PATH and COMSPEC. Importantly, TEMP or TMP is not
available, which causes a problem for generating temporary file names, and
on Windows, that breaks OpCache.

Often, php.ini-development will just be renamed to php.ini. Since $_ENV
isn't preferred anymore, run-test.php shouldn't be dependent on it.

I can fix this myself, but would like to know the preferred solution.

I suggest any of these fixes:

1. die if variables_order doesn't include "E"
2. die if $_ENV is empty: lots of tests will be false fails if no env vars
are set, so prevent getting to that point.
3. use getenv() to read common environment variables(TEMP or TMP) at
least.  getenv() doesn't provide a list of environment variable names, and
ideally it would just copy all of them, so try to use $_ENV and only use
getenv() if TEMP or TMP is not set.    and then die if $_ENV is still empty.


Regards
-M

--001a11461ea8dc043c054e86c97c--