Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:98888 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 47930 invoked from network); 26 Apr 2017 22:10:21 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 26 Apr 2017 22:10:21 -0000 Authentication-Results: pb1.pair.com header.from=php@golemon.com; sender-id=softfail Authentication-Results: pb1.pair.com smtp.mail=php@golemon.com; spf=softfail; sender-id=softfail Received-SPF: softfail (pb1.pair.com: domain golemon.com does not designate 74.125.82.53 as permitted sender) X-PHP-List-Original-Sender: php@golemon.com X-Host-Fingerprint: 74.125.82.53 mail-wm0-f53.google.com Received: from [74.125.82.53] ([74.125.82.53:36101] helo=mail-wm0-f53.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 9F/05-24892-CCA11095 for ; Wed, 26 Apr 2017 18:10:20 -0400 Received: by mail-wm0-f53.google.com with SMTP id u65so1941374wmu.1 for ; Wed, 26 Apr 2017 15:10:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=golemon-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-transfer-encoding; bh=1M8uUC+scaBgf60kLacz/aXA0aG7xycdDAN4WT+Ghi8=; b=OLkr2jQB+2CKo9apoUpGCDr9ykTzHsptSseAFbsH3o2BdBANTMRTBQv0ufeWWXdZBq ovd8wiGLZYXhcqrlI+N4X9/ph3nUKq2gONTcWGVzd5NdvTG+FMpijFeJrZbj31iWZBk9 rHwXIW+pFCW20i3IrnM6MzEqc/k1kt6gZ2xkdFAPvj+5Zlf60RLpjmwF9U9+QwROlJG2 qleRvtOrXs68l/pTTai2G7zaUuBpMkVam+D8LZFVBbvr08afJVgdIcv4xykw6OeUqBrw 1cZ5Zyzftmvs+d3bYZY2nwPDEu27XaEQnEiFf8mdalFmKNC8ItThDEm9aadCxjEGJMOd xUxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc:content-transfer-encoding; bh=1M8uUC+scaBgf60kLacz/aXA0aG7xycdDAN4WT+Ghi8=; b=jxFliMB3+fAKauIs3H2YnXXo1Bcg9vbxacWZTazseb2Sxz/tqmwWBspe8SttKtF0TN zszpXwOr+k87xyz2qjs4um2ZzJb63Dgf98wwNKCf39XC3G61g9gb40Y1MWLtE6w4hQyj H3/sSCEAxsjmfPeaHOvHM7V70IkawbouvVcBHPx5J+FFYvApprlSebAjF7DcbbMxZeDX kuDt6ARtUGLfo7ScaqdJvUuYBcWS5lFg+vXtwgqQrDPsvxVMUpM92D5o9M4l1nh+2KOk kQ/IzsiG/uVtTyND9NavhS/eadbyGF1o6lfsVSavglhmgoLunYvEhxQQzre4sxVu+aDo pzWA== X-Gm-Message-State: AN3rC/6oSthgYEbg7kd1b/vSZ/acpjnNSknaaS3E7ZidwcnMYBWCTQjl FW0uL6ZXhcGc9GH/C3HgHNsHzPOyog== X-Received: by 10.28.218.67 with SMTP id r64mr209935wmg.36.1493244617411; Wed, 26 Apr 2017 15:10:17 -0700 (PDT) MIME-Version: 1.0 Sender: php@golemon.com Received: by 10.223.157.38 with HTTP; Wed, 26 Apr 2017 15:10:16 -0700 (PDT) X-Originating-IP: [73.9.224.155] In-Reply-To: References: Date: Wed, 26 Apr 2017 17:10:16 -0500 X-Google-Sender-Auth: okYY6oX78Ksyt0MSYyZoFmIaL0k Message-ID: To: Anatol Belski Cc: PHP internals , Joe Watkins , Davey Shafik , Remi Collet Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [PHP-DEV] On malformed transport strings From: pollita@php.net (Sara Golemon) On Wed, Apr 26, 2017 at 1:19 PM, Anatol Belski wrote: > What I'd basically avoid is making changes in stress, > as there might be other beyond places and we shouldn't > risk to introduce more breach than there already is. > Instead, that requires a cold head and a lot of QA =F0=9F=98=89 > Which is precisely why I'm advocating reverting the whole lot. I've just sat down to try to at least address the mysqli_connect part and it's hairy. Basically we've built in precisely the kind of bad assumption that I was initially grousing about frameworks having done. I don't mean to ignore the security issue presented by 74216, I just recognize that my initial fix was made hastily and we should allocate more time to fix it properly (with all that lovely QA and testing). -Sara