Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:98865
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: softfail (pb1.pair.com: domain golemon.com does not designate 74.125.82.54 as permitted sender)
MIME-Version: 1.0
Sender: php@golemon.com
In-Reply-To: <82da5975-aaca-580c-50ae-0b034d14b124@fleshgrinder.com>
References: <CAJaRsPsfWtKbke8VvM-na=vCm0E6T62gmamj2V8sJiHRFB7FLQ@mail.gmail.com>
 <a5230c9c-c699-322b-ba56-09e74049b41b@gmail.com> <82da5975-aaca-580c-50ae-0b034d14b124@fleshgrinder.com>
Date: Mon, 24 Apr 2017 15:50:32 -0700
Message-ID: <CAESVnVrqD6HRij1zOd6Q5mmpE867=+r=XmFpL_z=V2aGvGeLnw@mail.gmail.com>
To: PHP internals <internals@lists.php.net>
Cc: Stanislav Malyshev <smalyshev@gmail.com>, "Colin O'Dell" <colinodell@gmail.com>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] [RFC] Enable strict_types checking for curl_setopt()
From: pollita@php.net (Sara Golemon)

On Mon, Apr 24, 2017 at 1:24 PM, Fleshgrinder <php@fleshgrinder.com> wrote:
> On 4/24/2017 10:20 PM, Stanislav Malyshev wrote:
>> Hi!
>>
>>> Because each option expects the value to be a specific type, it makes sense
>>> to enforce these types in strict type checking mode.  I'd therefore like to
>>> propose that we introduce strict type enforcement inside curl_setopt() when
>>> "declare(strict_types=1);" is being used.
>>
>> While it may make sense to check types per-option, that's not exactly
>> what scalar types are supposed to do - this is not argument typing, this
>> is internal function business logic, and I am not sure confusing the two
>> is really that good an idea.
>>
>
> I completely agree with Stanislav at this point. `curl_setopt` can and
> probably should validate the types of the various options, it may even
> throw a `TypeError`, but it most certainly should not depend on the
> `strict_types` declaration.
>
I disagree. From the user's perspective it is argument typing.  The
internal implementation detail of that argument type being dependent
on another arg's value is just a detail.

-Sara