Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:98810
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.192.180 as permitted sender)
To: Nikita Popov <nikita.ppv@gmail.com>, Derick Rethans <derick@php.net>
References: <alpine.DEB.2.20.1704151624210.2260@singlemalt.home.derickrethans.nl>
 <CAF+90c8ExHwbtj250UotjYu4mCwvj0yGBr-j-z4mv5_1N3dcow@mail.gmail.com>
Cc: PHP Developers Mailing List <internals@lists.php.net>
Message-ID: <1c651049-c92e-80c3-39c7-684ddbdc5f01@gmail.com>
Date: Sat, 15 Apr 2017 14:38:52 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:45.0)
 Gecko/20100101 Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: <CAF+90c8ExHwbtj250UotjYu4mCwvj0yGBr-j-z4mv5_1N3dcow@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Re: Inconsistency in line numbers.
From: smalyshev@gmail.com (Stanislav Malyshev)

Hi!

> behavior I wasn't aware of: https://3v4l.org/6fSRb In backtraces the call
> is located on the line of it's last argument (in PHP 5.6 the line of the
> closing ")"). Wouldn't it make more sense to use the starting line of the
> call? That is, use the same lineno for INIT_FCALL and DO_FCALL?

Since the call happens after evaluating the arguments, if you debug in
IDE and go through the arguments, it'll make IDE prompt jump back
sometimes. Not sure it's a good. Logically, it looks like first argument
eval happens, then call happens, so linking it to ")" makes sense (if
you read it left to right, that's kind of the point where the actual
call happens).

-- 
Stas Malyshev
smalyshev@gmail.com