Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:98773
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain beccati.com designates 176.9.123.236 as permitted sender)
To: internals@lists.php.net
References: <CADxrgCMB6iz3XX-+yRp0vY0AVWuuL=VwrdLND_78GF0Vhu0K9w@mail.gmail.com>
 <5e3e3e9b-f5b9-a19e-c4cb-6af0f5985d94@beccati.com>
 <CADxrgCP1wa_HiDCujXZV1oEN0CXDzg32VkWDoOaa17s-+bQ9UQ@mail.gmail.com>
 <be118423-73db-8b1d-3461-91156dd09d54@beccati.com>
 <CF.A4.18853.7A11DE85@pb1.pair.com>
Cc: Andrea Faulds <ajf@ajf.me>
Message-ID: <8923084a-a357-91e9-44b5-52a4af0a5df1@beccati.com>
Date: Wed, 12 Apr 2017 00:52:50 +0200
MIME-Version: 1.0
In-Reply-To: <CF.A4.18853.7A11DE85@pb1.pair.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] [RFC] PDO Float Type
From: php@beccati.com (Matteo Beccati)

Hi Andrea,

On 11/04/2017 19:25, Andrea Faulds wrote:
> Matteo Beccati wrote:
>> a PDO::PARAM_NUMERIC const that could in fact just be an alias for
>> PDO::PARAM_STR for most of the drivers
> 
> This is a technical solution to a documentation problem.

Yes, and I'd tend to agree. But technically PDO::PARAM_NUMERIC could
also allow to pass parameters in an appropriate format: I believe it
wouldn't be much of an improvement for pdo_pgsql, but to be certain some
level of investigation would be required.

> I think it runs the risk of confusing people who do know what they're
> doing, and assume NUMERIC is like FLOAT.

Hey, that was precisely my point! ;)

I.e. to assume that numeric and float are similar enough that
PDO::PARAM_FLOAT would be a good fit for a numeric field.

I know you meant it the other way around, but to me it is more confusing
to use PARAM_STR for numerics when only PARAM_FLOAT is available as
alternative vs using PARAM_FLOAT on a numeric when both are available.


> I'd suggest adding a warning to the manual instead.

I think that's a requirement in any case.


Cheers
-- 
Matteo Beccati

Development & Consulting - http://www.beccati.com/