Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:98757
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain kelunik.com from 81.169.146.220 cause and error)
MIME-Version: 1.0
In-Reply-To: <CACwt+Je85cp-t0y+GEP8JpuFb3CVq=xNH9r5WWEG2-T+aHUKtA@mail.gmail.com>
References: <CAOv67gvSwcecO30_ufkH7D0HyZ9inqnCq9yQHrfL_t50vri3hg@mail.gmail.com>
 <CACwt+Je85cp-t0y+GEP8JpuFb3CVq=xNH9r5WWEG2-T+aHUKtA@mail.gmail.com>
Date: Mon, 10 Apr 2017 13:04:31 +0200
Message-ID: <CANUQDCj4b6UaCqaW-OFqeOGvc1ghzi7WmqmNCvYTq4D+1WF53w@mail.gmail.com>
To: Patrick ALLAERT <patrickallaert@php.net>
Cc: Wes <netmo.php@gmail.com>, PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=94eb2c0c5c72983d7b054ccdf0f1
Subject: Re: [PHP-DEV][RFC][VOTE] Allow abstract function override
From: me@kelunik.com (Niklas Keller)

--94eb2c0c5c72983d7b054ccdf0f1
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

2017-04-10 11:34 GMT+02:00 Patrick ALLAERT <patrickallaert@php.net>:

> Le mar. 28 mars 2017 =C3=A0 06:51, Wes <netmo.php@gmail.com> a =C3=A9crit=
 :
>
> > Hello PHPeeps,
> >
> > There hasn't been much discussion around the proposed feature, and I've
> > interpreted it as a good sign :P It is not a super important change but
> it
> > has some advantages, it's consistent with the recent improvements to ty=
pe
> > variance and also with future ones. Also, it's hopefully not too hard t=
o
> > implement.
> >
> > https://wiki.php.net/rfc/allow-abstract-function-override
> >
> > I've decided to start the vote. It will end two weeks from this message=
,
> on
> > 10th April 2017.
> >
> > Thanks in advance for participating.
> >
> > Wes
> >
>
> Hello,
>
> Voted "no" because the RFC starts with:
>
> "
> PHP 7 introduced type declarations for return and improved ones for
> parameters. They currently support a very limited kind of variance (only =
to
> no-type):
>
> <?php
> class A { function bar(stdClass $x){} }
> class B extends A { function bar($x): stdClass{} }
> "
>
> Which looks false in both PHP 7.0 and PHP 7.1.
>
> Sorry if I missed something in a past discussions, but it looks wrong to =
me
> to implement anything based on a false assertion.
>
> I would be happy to change my vote if you can fix the RFC and/or enlight
> me.
>
> Cheers,
> Patrick
>

It's implemented in PHP 7.2 (master).

Regards, Niklas

--94eb2c0c5c72983d7b054ccdf0f1--