Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:98735
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: softfail (pb1.pair.com: domain golemon.com does not designate 209.85.128.175 as permitted sender)
MIME-Version: 1.0
Sender: php@golemon.com
In-Reply-To: <0B2BAD15-48AB-4095-A675-C2763ED2D91D@cschneid.com>
References: <CAGa2bXbvB7VBEBr89z3Ejbp3ZVLtqiQqnSQ3sspfBwV0L_k2TA@mail.gmail.com>
 <45858E8B-05A8-4EAB-97B0-A17C3D8BDD96@cschneid.com> <CAGa2bXaSf=ynWQ+D=cGWR1QmWWNsdGM5wv6XKLe43PtjvPL7Hg@mail.gmail.com>
 <0B2BAD15-48AB-4095-A675-C2763ED2D91D@cschneid.com>
Date: Wed, 5 Apr 2017 10:58:15 -0500
Message-ID: <CAESVnVqop=cz3BAL87RtBbd3nzdwbPjqMV3b+_MJnMW+Jk2t7Q@mail.gmail.com>
To: Christian Schneider <cschneid@cschneid.com>
Cc: Yasuo Ohgaki <yohgaki@ohgaki.net>, "internals@lists.php.net" <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] SHA3 is very slow
From: pollita@php.net (Sara Golemon)

On a similarly superficial scan, I have no issues with this.

The only tiny thing which gives me pause is
https://github.com/php/php-src/pull/2453/files#diff-0bb62bbdac4073ae183a857=
299826533R24
as I don't recall 100% if that redefinition will leak out to other
parts of the runtime (my instinct says it will, so that might need to
live in a different spot).

As long as the unit tests continue to pass (I assume they do) and the
licensing on the bundled library is favorable (it seems to be), it's
just one fast implementation in exchange for a slow one.

-Sara

On Wed, Apr 5, 2017 at 10:45 AM, Christian Schneider
<cschneid@cschneid.com> wrote:
> Am 05.04.2017 um 04:31 schrieb Yasuo Ohgaki <yohgaki@ohgaki.net>:
>> PHP's sha3 seems slower than it could be.
>
> I created a pull request at https://github.com/php/php-src/pull/2453 for =
a version using the KeccakCodePackage version from https://github.com/gvana=
s/KeccakCodePackage which yields ~30 times faster results for a simple test=
.
>
> I don't know whether the PHP maintainers prefer to keep the (very short) =
inline reference implementation which is slow or whether the optimised vers=
ion from KeccakCodePackage with around a dozen files would be acceptable.
>
> I put the (part which is used from the) KeccakCodePackage code (without m=
odifications!) in a separate directory under ext/hash/sha3 and I also imple=
mented switching between a 64bit and a 32bit version. Don't know if this is=
 necessary and following all the guidelines.
>
> Oh, I also only superficially scanned
>         https://github.com/gvanas/KeccakCodePackage#under-which-license-i=
s-the-kcp-distributed
> but it looked like it should be ok. Not an expert on this though ;-)
>
> Regards,
> - Chris
>
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>