Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:98732
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.213.54 as permitted sender)
MIME-Version: 1.0
Date: Wed, 5 Apr 2017 09:18:49 -0300
Message-ID: <CAEsg9X2ho_atzhazD3_RkzY8VMuQ2wVeJb1FSoLdDNGwSfmf2w@mail.gmail.com>
To: PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a11432afc4350aa054c6a66a7
Subject: Throw an exception for possible file race condition
From: david.proweb@gmail.com (David Rodrigues)

--001a11432afc4350aa054c6a66a7
Content-Type: text/plain; charset=UTF-8

Currently we should uses the @-operator on mkdir(), for instance, to check
a race condition. Something like:

if (!@mkdir('test')) {
    throw new SomeException();
}

Should be fine if we can do something like that, instead:

try {
    mkdir('test');
}
catch (FileExistsException $exception) {
    throw new SomeException();
}

It will avoid the @-operator and make the result more reliable (for
instance, if you don't uses the @-operator in this case and is catched by a
race condition).

-- 
David Rodrigues

--001a11432afc4350aa054c6a66a7--