Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:98698
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.213.49 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CADqTB_i0YOfBibA+vj1RCCEOJjVLojy1f4SHYngGZE5MPjzqsQ@mail.gmail.com>
References: <CADqTB_irwt+Q74KJp-0mBnc6L4S+XoBoKqtN7DwK=oR4Dkk-CA@mail.gmail.com>
 <CAESVnVqFcYr4tYYwUe3m3tepCZAkbbvZfrKPzk_xWUG3Jr+ezw@mail.gmail.com>
 <CAKOpQSydVTHo1zUdafNrFNc+ciQ1LBWu7OM+Ts8GEsztT32K7Q@mail.gmail.com> <CADqTB_i0YOfBibA+vj1RCCEOJjVLojy1f4SHYngGZE5MPjzqsQ@mail.gmail.com>
Date: Fri, 31 Mar 2017 16:40:42 +0700
Message-ID: <CAEZPtU7W8r8AsZQf-BZ+RL32pofQ-HMnJyV5YA3uz+ewG8rWVw@mail.gmail.com>
To: Rasmus Schultz <rasmus@mindplay.dk>
Cc: Kris Craig <kris.craig@gmail.com>, Sara Golemon <pollita@php.net>, 
	PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] Directory separators on Windows
From: pierre.php@gmail.com (Pierre Joye)

On Fri, Mar 31, 2017 at 3:32 PM, Rasmus Schultz <rasmus@mindplay.dk> wrote:
> Well, this is the opposite of what I'm asking for, and does not address the
> case where paths have been persisted in a file or database and the data
> gets accessed from different OS.
>
> I understand the reasons given for not changing this behavior in PHP
> itself, so maybe we could have a standard function that normalizes paths to
> forward slashes? e.g. basically:
>
> /**
>  * Normalize a filesystem path.
>  *
>  * On windows systems, replaces backslashes with forward slashes
>  * and ensures drive-letter in upper-case.
>  *
>  * @param string $path
>  *
>  * @return string normalized path
>  */
> function normalize_path( $path ) {
>     $path = str_replace('\\', '/', $path);
>
>     return $path{1} === ':'
>         ? ucfirst($path)
>         : $path;
> }

Also ucfirst is useless (or any case operations). realpath goes
further down by solving ugly things like  \\\\\\\ or ////// (code
concatenating paths without checking trailing /\.

> At least WordPress, Drupal and probably most major CMS and frameworks have
> this function or something equivalent. .

Now I remember why they have to do that.

realpath is not fully exposed in userland. virtual_file_ex should be
used and provide the option to validate path or not. Right now
realpath will fail if the path does not exist. I would suggest to
expose this functionality/option and that will solve the need to
implement such things in userland.

ps: I discussed that long time with Dmitry and forgot to implement it,
I take the blame for not having that in 7.x :)

Cheers,
Pierre