Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:98625
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.161.170 as permitted sender)
MIME-Version: 1.0
Sender: jakub.php@gmail.com
In-Reply-To: <CAEKnhAHueT=AWX_zA8ziAvC5i=HHmJnGk6Ocj94cM_Zq8=m3Tw@mail.gmail.com>
References: <CACXBjuhUphs7uZwFCn+18_DLC=Dcyg_TTyJRS7dLFfjNmP5f2Q@mail.gmail.com>
 <CAEKnhAHtXJp7UY49moWbJN+0VOeYaxCs_erf4=X4Od4yz4Mh3Q@mail.gmail.com>
 <CACXBjujSC4kwv1otKPkm7eA0yTh+HkQRr3GFPFmXCHdhnyhYsg@mail.gmail.com>
 <1c18a6eb-452a-9d9a-b9ef-8f19a44f7dae@fedoraproject.org> <CAEKnhAEoxBji7768jJ5L4N01sqWX7AhEvGGQ6REP-kboox815g@mail.gmail.com>
 <c92b7a80-2559-ed31-188c-224a33ddc340@fedoraproject.org> <CAEKnhAHueT=AWX_zA8ziAvC5i=HHmJnGk6Ocj94cM_Zq8=m3Tw@mail.gmail.com>
Date: Fri, 24 Mar 2017 19:31:38 +0000
Message-ID: <CAEKnhAFe5N1daBgctC27PmBM8n3tFgLn_KaN6zx7O8N4b6dp1w@mail.gmail.com>
To: PHP Internals <internals@lists.php.net>
Cc: Rasmus Lerdorf <rasmus@lerdorf.com>, Remi Collet <remi@fedoraproject.org>, 
	Anatol Belski <ab@php.net>
Content-Type: multipart/alternative; boundary=f403045ebe10d8f723054b7f0a59
Subject: Re: [PHP-DEV] Re: PHP 7.0 and openssl 1.1
From: bukka@php.net (Jakub Zelenka)

--f403045ebe10d8f723054b7f0a59
Content-Type: text/plain; charset=UTF-8

Hi,

On Sun, Mar 12, 2017 at 10:28 PM, Jakub Zelenka <bukka@php.net> wrote:

> Hi,
>
> On Sun, Mar 12, 2017 at 1:49 PM, Remi Collet <remi@fedoraproject.org>
> wrote:
>
>> >> But as said by Rasmus, there is tons of extensions and libraries linked
>> >> against openssl, and having both versions loaded in the same process
>> can
>> >> only be a huge mess, and raise terrible issues.
>>
>> Here is a minimal patch which seems ok (test suite passes)
>>
>> https://github.com/remicollet/remirepo/blob/master/scl-php70
>> /php/php-7.0.17-openssl11.patch
>>
>> If it may helps some other dev, which need to build 7.0 on a recent
>> distro...
>>
>>
After thinking about it and considering that distros patching the 7.0
openssl ext just for the OpenSSL 1.1 support, I started working on the
complete patch for 7.0 only. I wanted to initially start with the above one
but after I get it from Remi's history (the link above doesn't work), I
noticed that there are lots of missing bits and it doesn't even apply. So I
started from scratch - backported the related stuff from 7.1 and port old
openssl_(en|de)crypt. It's only in openssl.c for now. I haven't tested it
yet with OpenSSL 1.1 (which I will doing later) but it works with 1.0.2.
It's still a WIP but wanted to give you an update so you know that the work
is in progress. You can see all changes in here:

https://github.com/php/php-src/compare/PHP-7.0...bukka:openssl_1_1_for_7_0

Cheers

Jakub

--f403045ebe10d8f723054b7f0a59--