Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:98623
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.128.182 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAFMT4Nrx-xUhy5dErAr-tY0dG5fE-H93n8Zxs_XYDPZq1MWGZw@mail.gmail.com>
References: <CAF+90c9vdsLuh1GAB4VPbYzJp=XiH6a5w79t5Kt=JLV6=xkdDA@mail.gmail.com>
 <16.06.40046.20A35D85@pb1.pair.com> <CAFMT4Nrx-xUhy5dErAr-tY0dG5fE-H93n8Zxs_XYDPZq1MWGZw@mail.gmail.com>
Date: Fri, 24 Mar 2017 20:04:26 +0100
Message-ID: <CAF+90c_rz+kpgGEMn14vuxft7QNEpG611+gya6Jnv2dgoUBPMw@mail.gmail.com>
To: Levi Morrison <levim@php.net>
Cc: Andrea Faulds <ajf@ajf.me>, internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=f403043892d4991066054b7ea9f5
Subject: Re: [PHP-DEV] Re: TOKEN_AS_OBJECT for token_get_all()
From: nikita.ppv@gmail.com (Nikita Popov)

--f403043892d4991066054b7ea9f5
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Fri, Mar 24, 2017 at 5:26 PM, Levi Morrison <levim@php.net> wrote:

> On Fri, Mar 24, 2017 at 9:23 AM, Andrea Faulds <ajf@ajf.me> wrote:
> > Hi Nikita,
> >
> > Nikita Popov wrote:
> >
> >> I'd like to add a new TOKEN_AS_OBJECT flag to token_get_all(), which
> >> returns an array of PhpToken objects, rather than the mix of plain
> strings
> >> and arrays we currently have. The PhpToken class is defined as:
> >>
> >> class PhpToken {
> >>     public $type;
> >>     public $text;
> >>     public $line;
> >> }
> >
> >
> > Rather than adding a flag to token_get_all() to return objects, you cou=
ld
> > potentially instead make an equivalent static method on PhpToken
> > (PhpToken::getAll() perhaps). That would avoid mixing =E2=80=9Cobject-o=
riented=E2=80=9D
> and
> > =E2=80=9Cprocedural=E2=80=9D styles, though I don't know if it matters.=
 It seems cleaner
> to
> > me.
> >
> > Thanks!
> >
> > --
> > Andrea Faulds
> > https://ajf.me/
> >
> >
> > --
> > PHP Internals - PHP Runtime Development Mailing List
> > To unsubscribe, visit: http://www.php.net/unsub.php
>
> I prefer a distinct function/method from `token_get_all`. I don't see
> the value in having a return value that differs so much based on a
> passed flag. I don't care so much about a function vs static method; I
> just oppose the additional parameter to `token_get_all`.
>
> I like the idea very much overall aside from that detail.
>

token_get_all() already has a $flags parameter controlling its output.
Currently only the TOKEN_PARSE flag is supported, which changes the
interpretation of certain tokens. In a previous thread on this topic Sara
suggested another flag (something like TOKEN_ALWAYS_ARRAY) which makes the
output of token_get_all() consistently use arrays. I think handling this as
a flag is entirely reasonable, and by analogy, handling the object mode as
a flag is also reasonable. In the end, these are just minor variations on
the output format (minor relative to the very complex primary functionality
of the function: lexing). Another precedent is the json_decode() option to
use arrays or objects in the return value.

Regards,
Nikita

--f403043892d4991066054b7ea9f5--