Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:98619
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.214.43 as permitted sender)
MIME-Version: 1.0
Sender: morrison.levi@gmail.com
In-Reply-To: <16.06.40046.20A35D85@pb1.pair.com>
References: <CAF+90c9vdsLuh1GAB4VPbYzJp=XiH6a5w79t5Kt=JLV6=xkdDA@mail.gmail.com>
 <16.06.40046.20A35D85@pb1.pair.com>
Date: Fri, 24 Mar 2017 10:26:32 -0600
Message-ID: <CAFMT4Nrx-xUhy5dErAr-tY0dG5fE-H93n8Zxs_XYDPZq1MWGZw@mail.gmail.com>
To: Andrea Faulds <ajf@ajf.me>
Cc: internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] Re: TOKEN_AS_OBJECT for token_get_all()
From: levim@php.net (Levi Morrison)

On Fri, Mar 24, 2017 at 9:23 AM, Andrea Faulds <ajf@ajf.me> wrote:
> Hi Nikita,
>
> Nikita Popov wrote:
>
>> I'd like to add a new TOKEN_AS_OBJECT flag to token_get_all(), which
>> returns an array of PhpToken objects, rather than the mix of plain strin=
gs
>> and arrays we currently have. The PhpToken class is defined as:
>>
>> class PhpToken {
>>     public $type;
>>     public $text;
>>     public $line;
>> }
>
>
> Rather than adding a flag to token_get_all() to return objects, you could
> potentially instead make an equivalent static method on PhpToken
> (PhpToken::getAll() perhaps). That would avoid mixing =E2=80=9Cobject-ori=
ented=E2=80=9D and
> =E2=80=9Cprocedural=E2=80=9D styles, though I don't know if it matters. I=
t seems cleaner to
> me.
>
> Thanks!
>
> --
> Andrea Faulds
> https://ajf.me/
>
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php

I prefer a distinct function/method from `token_get_all`. I don't see
the value in having a return value that differs so much based on a
passed flag. I don't care so much about a function vs static method; I
just oppose the additional parameter to `token_get_all`.

I like the idea very much overall aside from that detail.