Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:98618
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.213.53 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <16.06.40046.20A35D85@pb1.pair.com>
References: <CAF+90c9vdsLuh1GAB4VPbYzJp=XiH6a5w79t5Kt=JLV6=xkdDA@mail.gmail.com>
 <16.06.40046.20A35D85@pb1.pair.com>
Date: Fri, 24 Mar 2017 12:33:55 -0300
Message-ID: <CAEsg9X07tHkKVoQte3hzrfF+zuxRov0eTS9rbgQ7F3+w0VSk7A@mail.gmail.com>
To: Andrea Faulds <ajf@ajf.me>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=f403045e2966b67f2a054b7bb8ae
Subject: Re: [PHP-DEV] Re: TOKEN_AS_OBJECT for token_get_all()
From: david.proweb@gmail.com (David Rodrigues)

--f403045e2966b67f2a054b7bb8ae
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Em 24 de mar de 2017 12:24 PM, "Andrea Faulds" <ajf@ajf.me> escreveu:

Hi Nikita,


Nikita Popov wrote:

I'd like to add a new TOKEN_AS_OBJECT flag to token_get_all(), which
> returns an array of PhpToken objects, rather than the mix of plain string=
s
> and arrays we currently have. The PhpToken class is defined as:
>
> class PhpToken {
>     public $type;
>     public $text;
>     public $line;
> }
>

Rather than adding a flag to token_get_all() to return objects, you could
potentially instead make an equivalent static method on PhpToken
(PhpToken::getAll() perhaps). That would avoid mixing =E2=80=9Cobject-orien=
ted=E2=80=9D and
=E2=80=9Cprocedural=E2=80=9D styles, though I don't know if it matters. It =
seems cleaner to
me.

I liked your suggestion. Maybe just change to something like
SplTokenizer::parse(): SplToken[]


Thanks!

--=20
Andrea Faulds
https://ajf.me/


--=20
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

--f403045e2966b67f2a054b7bb8ae--