Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:98610
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.52 as permitted sender)
MIME-Version: 1.0
Date: Thu, 23 Mar 2017 18:16:31 +0100
Message-ID: <CAF+90c9vdsLuh1GAB4VPbYzJp=XiH6a5w79t5Kt=JLV6=xkdDA@mail.gmail.com>
To: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a11444cb8cee222054b6909f0
Subject: TOKEN_AS_OBJECT for token_get_all()
From: nikita.ppv@gmail.com (Nikita Popov)

--001a11444cb8cee222054b6909f0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hi internals,

I'd like to add a new TOKEN_AS_OBJECT flag to token_get_all(), which
returns an array of PhpToken objects, rather than the mix of plain strings
and arrays we currently have. The PhpToken class is defined as:

class PhpToken {
    public $type;
    public $text;
    public $line;
}

This has been previously suggested and implemented by Rouven We=C3=9Fling [=
1],
I've just ported this feature to master and optimized the implementation
[2].

Apart from being a nicer interface than the current format, an additional
advantage is that the  TOKEN_AS_OBJECT mode uses about 1.8x less memory and
is 1.4x times faster.

Are there any objections to this change?

Regards,
Nikita

[1]: https://github.com/php/php-src/pull/1727
[2]: https://github.com/php/php-src/pull/2430

--001a11444cb8cee222054b6909f0--