Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:98551
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.216.171 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAObuZdsOFSjBGVNEkNPWtYe1xzdOSto=S_VhwGQnm59rHN7DqA@mail.gmail.com>
References: <CAGyGae2yg-NnPmcJEJcPdn3XQTUyS_=Ymg1nrdTDTig9r2rdfw@mail.gmail.com>
 <CADyq6sKASo_nV9SvvG6LXKCEOY-H=ofuQqbSwAA08TMb1T_Rmg@mail.gmail.com>
 <CAJW__o3F1=4ou-Wmfv0JsQnnYNj_CqRLFxzEweNJvM3nZz8t2w@mail.gmail.com>
 <CADyq6sJMTkthzrRkOqwj9M=jkp0Be6T6Ry1kQuwyb7VOEa+N1A@mail.gmail.com> <CAObuZdsOFSjBGVNEkNPWtYe1xzdOSto=S_VhwGQnm59rHN7DqA@mail.gmail.com>
Date: Wed, 15 Mar 2017 23:40:47 +0100
Message-ID: <CADyq6sLWukWaerw-enD1VMEYiDPr4BPy8Nz9xkN+3o2qLgCzXA@mail.gmail.com>
To: Ryan Pallas <derokorian@gmail.com>
Cc: PHP Internals List <internals@lists.php.net>, =?UTF-8?Q?Beno=C3=AEt_Burnichon?= <bburnichon@gmail.com>, 
	Kalle Sommer Nielsen <kalle@php.net>
Content-Type: multipart/alternative; boundary=001a113d0ce6c34efc054acca2f3
Subject: Re: [PHP-DEV] Add __toArray() method to objects that would be called
 on cast to array
From: ocramius@gmail.com (Marco Pivetta)

--001a113d0ce6c34efc054acca2f3
Content-Type: text/plain; charset=UTF-8

Which is precisely the BC break: such a library would now throw an
exception "unsupported class X" when `__toString` is implemented. Also,
such a library would break silently when this feature is implemented.

Much like the already very broken `__debugInfo()`, this automatic type-cast
is a giga-Joule footgun.

On 15 Mar 2017 11:36 p.m., "Ryan Pallas" <derokorian@gmail.com> wrote:

>
>
> On Wed, Mar 15, 2017 at 4:33 PM, Marco Pivetta <ocramius@gmail.com> wrote:
>
>> It's the only way to distinguish between set and unset properties. Also
>> the
>> only way to get all properties from an instance of an inheritance tree.
>> Also, it's covered by tests that were explicitly added to prevent
>> regressions on this.
>>
>> Same as all similar discussions before this one: need an alternative way
>> to
>> do things before proposing a BC break.
>>
>>
> As mentioned in previous mails - the intent isn't to change existing
> behaviour, but to provide a way for a class to override the default
> behaviour. As long as those classes you are casting to array don't
> implement __toArray they will behave exactly as they always have. The only
> concern then, is that you might be relying on a library to not implement
> that function on a class you are casting.
>
>
>> On 15 Mar 2017 11:27 p.m., "Kalle Sommer Nielsen" <kalle@php.net> wrote:
>>
>> > Hi
>> >
>> > 2017-03-15 21:41 GMT+01:00 Marco Pivetta <ocramius@gmail.com>:
>> > > This is a BC break due to the fact that the `(array)` cast is used to
>> > > extract property information from private properties in library code.
>> >
>> > Yep, but then again that is more of an
>> > undocumented-not-really-supported case afair, if anything then
>> > Reflection should have the APIs to officially allow that, although I
>> > am still skeptic of this.
>> >
>> >
>> > --
>> > regards,
>> >
>> > Kalle Sommer Nielsen
>> > kalle@php.net
>> >
>>
>
>

--001a113d0ce6c34efc054acca2f3--