Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:98540
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.182 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAGyGae2yg-NnPmcJEJcPdn3XQTUyS_=Ymg1nrdTDTig9r2rdfw@mail.gmail.com>
References: <CAGyGae2yg-NnPmcJEJcPdn3XQTUyS_=Ymg1nrdTDTig9r2rdfw@mail.gmail.com>
Date: Wed, 15 Mar 2017 12:13:58 -0600
Message-ID: <CAObuZdsJK3eUMb1EzumdOeue1+YoOSVy-7tdYCV4+WmnjjfhOg@mail.gmail.com>
To: =?UTF-8?Q?Beno=C3=AEt_Burnichon?= <bburnichon@gmail.com>
Cc: "internals@lists.php.net" <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a11c183bc8aff1a054ac8e80a
Subject: Re: [PHP-DEV] Add __toArray() method to objects that would be called
 on cast to array
From: derokorian@gmail.com (Ryan Pallas)

--001a11c183bc8aff1a054ac8e80a
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Wed, Mar 15, 2017 at 11:49 AM, Beno=C3=AEt Burnichon <bburnichon@gmail.c=
om>
wrote:

> Hi all,
>
> Looking at code of PHPUnit, I stumbled upon an inconsistent array
> conversion:
>
> ------
> /**
>  * @param ArrayAccess|array $other
>  */
> function evaluate($other)
> {
>   // type cast $other as an array to allow
>   //support in standard array functions.
>   if ($other instanceof ArrayAccess) {
>     $data =3D (array) $data;
>   }
>
>   $patched =3D array_replace_recursive($other, $this->subset);
>
>   // ...
> }
> -----
>
> This would work only for `ArrayAccess` implementations extending
> `ArrayObject` as shown by https://3v4l.org/ti4aY
>
> Looking at the manual
> http://php.net/manual/en/language.types.array.php#
> language.types.array.casting
> ,
> it seems `ArrayObject` class does not comply to array casting because
> integer public properties could also be retrieved. Some tests showed that
> regular class always have string keys even when a `$key =3D 0; $this->{$k=
ey}
> =3D 'avalue';` is called. In this case, `var_export((array)$object);` ret=
urns
> `array('0' =3D> 'avalue')` (Notice the quote around key 0 -
> https://3v4l.org/6QW70)
>
> What do you think of adding an optional `__toArray()` method to classes
> which would default to current behavior but would allow specifying
> behavior. The way of internal `__toString()` method and could explain
> inconsistency of the `ArrayObject` class?
>

I like the idea kind of, but would this remove the ability to cast to array
all classes not implementing __toArray, as is the case with __toString?
This would be a HUGE BC if so:

$ php -r 'class Foo {public $foo =3D "foobar";} var_dump((array) (new Foo))=
;'
array(1) {
  ["foo"]=3D>
  string(6) "foobar"
}
$ php -r 'class Foo {public $foo =3D "foobar";} var_dump((string) (new Foo)=
);'
PHP Recoverable fatal error:  Object of class Foo could not be converted to
string in Command line code on line 1
$ php -v
PHP 7.1.2 (cli) (built: Feb 27 2017 00:02:44) ( ZTS )


> Regards,
>
> Beno=C3=AEt Burnichon
>

--001a11c183bc8aff1a054ac8e80a--