Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:98539
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.53 as permitted sender)
MIME-Version: 1.0
Date: Wed, 15 Mar 2017 17:49:40 +0000
Message-ID: <CAGyGae2yg-NnPmcJEJcPdn3XQTUyS_=Ymg1nrdTDTig9r2rdfw@mail.gmail.com>
To: internals@lists.php.net
Content-Type: multipart/alternative; boundary=001a11452cac3dcad2054ac89279
Subject: Add __toArray() method to objects that would be called on cast to array
From: bburnichon@gmail.com (=?UTF-8?Q?Beno=C3=AEt_Burnichon?=)

--001a11452cac3dcad2054ac89279
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hi all,

Looking at code of PHPUnit, I stumbled upon an inconsistent array
conversion:

------
/**
 * @param ArrayAccess|array $other
 */
function evaluate($other)
{
  // type cast $other as an array to allow
  //support in standard array functions.
  if ($other instanceof ArrayAccess) {
    $data =3D (array) $data;
  }

  $patched =3D array_replace_recursive($other, $this->subset);

  // ...
}
-----

This would work only for `ArrayAccess` implementations extending
`ArrayObject` as shown by https://3v4l.org/ti4aY

Looking at the manual
http://php.net/manual/en/language.types.array.php#language.types.array.cast=
ing
,
it seems `ArrayObject` class does not comply to array casting because
integer public properties could also be retrieved. Some tests showed that
regular class always have string keys even when a `$key =3D 0; $this->{$key=
}
=3D 'avalue';` is called. In this case, `var_export((array)$object);` retur=
ns
`array('0' =3D> 'avalue')` (Notice the quote around key 0 -
https://3v4l.org/6QW70)

What do you think of adding an optional `__toArray()` method to classes
which would default to current behavior but would allow specifying
behavior. The way of internal `__toString()` method and could explain
inconsistency of the `ArrayObject` class?

Regards,

Beno=C3=AEt Burnichon

--001a11452cac3dcad2054ac89279--