Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:98527 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 2310 invoked from network); 14 Mar 2017 23:39:09 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 14 Mar 2017 23:39:09 -0000 Authentication-Results: pb1.pair.com header.from=php@golemon.com; sender-id=softfail Authentication-Results: pb1.pair.com smtp.mail=php@golemon.com; spf=softfail; sender-id=softfail Received-SPF: softfail (pb1.pair.com: domain golemon.com does not designate 74.125.82.44 as permitted sender) X-PHP-List-Original-Sender: php@golemon.com X-Host-Fingerprint: 74.125.82.44 mail-wm0-f44.google.com Received: from [74.125.82.44] ([74.125.82.44:35956] helo=mail-wm0-f44.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id A4/F9-38004-A1F78C85 for ; Tue, 14 Mar 2017 18:39:07 -0500 Received: by mail-wm0-f44.google.com with SMTP id n11so75694266wma.1 for ; Tue, 14 Mar 2017 16:39:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=golemon-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=Z2TbOdbBqM069qkoVvxYnu/1WO9FC56q/kjiaw7lKto=; b=H3Nfj1tki23Kxrvl/JFlxUk5s78Djg6jZLJ6eqjgXkHRcavbaBa6aRFkTtHS/8MlnW be0XaJ5HznBDWz7drAEQE5GJ1w8cBXvKkTGRbN+c5J5hToZ1Xziu81c7thR/xMoeorpV Ie77cBgWaIZzQ4gL5/tehmS7T46fcJ3kIf6B0eQ4a6+tnEdCQ1iEgScuTB7FfVyx1phT xtnDm3Tf9lOfdtMOjwp3fqKZ5aXFotEMOIMmwCrK+aWwbVLQadgmdgoiR7eiQn+IAuju vIuuj0gH3ToXcmCYfYWrOIPFWM7hIb5zDl1mGdiVPsPorAUnDX+h73KnySRE3TdeCNwE Jsrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=Z2TbOdbBqM069qkoVvxYnu/1WO9FC56q/kjiaw7lKto=; b=kTP39h4/fFZikkabUPAmuNr4e3RCRZvL12ZuY4CKgYBRvkljUUqwkGcyQbdc1beR6B DPvdWVef8L5+GzJMl6T9W+hD/rqP9d04LA5GV6YD+if6zNjmUrzIbfUhtCfmXcVpn0Y/ flc+M5OJwzZy4Xv7IQhAEWQvLS8tMMVClNS7pcwyHZqeS9LYg4O9GBZoKKJk2wavd/Td i/sYArbtqZlXyf+R8Qh10B7NMuyzNJmCicIPN49shUCXL04IWyA+1zeLtAMZikTaah8G d5/4Gy2GiVcB9D94anhFZSS0BeqEH+bHu8AnV5pxRHSGTp25WMeDBo8nCOnO+AGtJYJv eHtw== X-Gm-Message-State: AFeK/H2I6KX+Vku6djQZTZjcsHoOFLYVqiaP1nNUM/kQZS+2KgyeAM0kSW9xg3tcglIqjA78thJ7yjzjDpROKg== X-Received: by 10.28.224.11 with SMTP id x11mr1879248wmg.98.1489534743531; Tue, 14 Mar 2017 16:39:03 -0700 (PDT) MIME-Version: 1.0 Sender: php@golemon.com Received: by 10.223.152.213 with HTTP; Tue, 14 Mar 2017 16:39:02 -0700 (PDT) X-Originating-IP: [73.9.224.155] In-Reply-To: References: Date: Tue, 14 Mar 2017 18:39:02 -0500 X-Google-Sender-Auth: 30ygpANxn0zE5qPi6_SGRQlJ6Bg Message-ID: To: Jesse Schalken Cc: Julien Pauli , PHP internals Content-Type: text/plain; charset=UTF-8 Subject: Re: [PHP-DEV] array_values should be a no-op for packed layout arrays From: pollita@php.net (Sara Golemon) On Tue, Mar 14, 2017 at 6:25 PM, Jesse Schalken wrote: > I didn't realise packed arrays could still have gaps. If that's the case, > why can't [12=>'foo', 42=>'bar'] be packed (index 0-11 and 13-41 are > undefined)? > It can be, but in practice isn't likely to be since that's a lot of empty space for a two element array. It will end up mixed pretty quickly before you get to that point. > I agree checking if the array is both packed and without gaps would still > make a worthwhile optimisation. > Oh yeah, btw... six hours ago... https://github.com/php/php-src/commit/c74bc87c74f48bc55541b3bf2fc67d595f58a3b5 -Sara