Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:98526
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.174 as permitted sender)
MIME-Version: 1.0
Sender: jesseschalken@gmail.com
In-Reply-To: <CAESVnVobH6dGJrSE2H96pW0RN3Ph6qzNZ=vWtBwpOZzA2FxFZQ@mail.gmail.com>
References: <CAF1yvARtzD9sm+mFknYMYbihkU4Ls7tXwVwiH=msa+KAgDKErQ@mail.gmail.com>
 <CAMUwpuSuaoO62s15=eLnHsYRPpA-t0N=96ObVugw_smg4PhAHw@mail.gmail.com> <CAESVnVobH6dGJrSE2H96pW0RN3Ph6qzNZ=vWtBwpOZzA2FxFZQ@mail.gmail.com>
Date: Wed, 15 Mar 2017 10:25:35 +1100
Message-ID: <CAF1yvARr_G0oB7L5F9UmpNJCmbY-0rYSwsknB5oht-bN_=BDAw@mail.gmail.com>
To: Sara Golemon <pollita@php.net>
Cc: Julien Pauli <jpauli@php.net>, PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a113cff1a1ec417054ab92543
Subject: Re: [PHP-DEV] array_values should be a no-op for packed layout arrays
From: me@jesseschalken.com (Jesse Schalken)

--001a113cff1a1ec417054ab92543
Content-Type: text/plain; charset=UTF-8

On Wed, Mar 15, 2017 at 3:48 AM, Sara Golemon <pollita@php.net> wrote:
>
> Minor nit: [12=>'foo', 42=>'bar'] is not a packed array.
>
> [0=>'foo', 2=>'bar'] is however, so your primary point stands.
> However it should be simple enough to detect when a packed array is
> also vector-like (indexed from 0 to n-1) and make this minor
> optimization.
>
> -Sara
>

I didn't realise packed arrays could still have gaps. If that's the case,
why can't [12=>'foo', 42=>'bar'] be packed (index 0-11 and 13-41 are
undefined)?

I agree checking if the array is both packed and without gaps would still
make a worthwhile optimisation.

--001a113cff1a1ec417054ab92543--