Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:98525
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.128.179 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.20.1703142219270.1973@singlemalt.home.derickrethans.nl>
References: <04.57.38004.22D38C85@pb1.pair.com> <alpine.DEB.2.20.1703142219270.1973@singlemalt.home.derickrethans.nl>
Date: Tue, 14 Mar 2017 23:59:35 +0100
Message-ID: <CAF+90c-Ok5s8M18sdw=3Cf_=7nHAp_ZF+s8c6my+5XT0Rv0Bdg@mail.gmail.com>
To: Derick Rethans <derick@php.net>
Cc: Andrea Faulds <ajf@ajf.me>, PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a1141b6a023390e054ab8c8a0
Subject: Re: [PHP-DEV] [PATCH] Make var_export() output "(object)array(..."
 instead of "stdClass::__set_state(..." for stdClass
From: nikita.ppv@gmail.com (Nikita Popov)

--001a1141b6a023390e054ab8c8a0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Tue, Mar 14, 2017 at 11:20 PM, Derick Rethans <derick@php.net> wrote:

> On Tue, 14 Mar 2017, Andrea Faulds wrote:
>
> > Hi everyone,
> >
> > Since stdClass has no __set_state method, var_export() produces unusabl=
e
> > output if given an object of that class. I wrote a patch that would mak=
e
> > var_export() produce a cast to object instead, which could be evaluated
> to get
> > back a stdClass:
> >
> > https://github.com/php/php-src/pull/2420
> >
> > Any thoughts/comments?
>
> As original author of var_export, I approve of this =E2=80=94 including n=
ot
> adding __set_state().
>
> cheers,
> Derick
>

I'm also +1 on this, and also prefer not having __set_state(). An object
cast is both more idiomatic and more performant.

Additionally I feel that adding methods to stdClass will muddy the waters
-- for example, this means that extending stdClass is no longer entirely
unreasonable, as you might want to do it to reuse the __set_state()
implementation. Not something I want to see happening.

Nikita

--001a1141b6a023390e054ab8c8a0--