Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:98523
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain mabe.berlin from 80.237.132.167 cause and error)
To: internals@lists.php.net
References: <04.57.38004.22D38C85@pb1.pair.com>
 <ba9562a8-8c05-9783-6455-e93b88f49a4b@fleshgrinder.com>
Message-ID: <156faa4f-b159-031d-23a2-7367f692dce0@mabe.berlin>
Date: Tue, 14 Mar 2017 21:01:04 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.7.0
MIME-Version: 1.0
In-Reply-To: <ba9562a8-8c05-9783-6455-e93b88f49a4b@fleshgrinder.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] [PATCH] Make var_export() output "(object)array(..."
 instead of "stdClass::__set_state(..." for stdClass
From: dev@mabe.berlin (Marc Bennewitz)



Am 14.03.2017 um 20:26 schrieb Fleshgrinder:
> On 3/14/2017 7:57 PM, Andrea Faulds wrote:
>> Hi everyone,
>>
>> Since stdClass has no __set_state method, var_export() produces unusable
>> output if given an object of that class. I wrote a patch that would make
>> var_export() produce a cast to object instead, which could be evaluated
>> to get back a stdClass:
>>
>> https://github.com/php/php-src/pull/2420
>>
>> Any thoughts/comments?
>>
>> If you're wondering about whether a __set_state method should be added
>> to stdClass, I posted some thoughts in the pull request discussion already.
>>
>> Thanks!
>
> I actually already used __set_state occasionally for userland classes.
> Adding __set_state to stdClass seems to be more consistent with the rest
> of PHP, rather than special casing it in one method. I cannot see any
> issues with this to be honest.
>

Personally I would like to have a more reasonable way in general. No 
special case and no magic method.

So my proposal then would be to try to add a class cast operator (needs 
an own RFC) and later to with this approach on var_export.

Example:

class Foo {}

$std = new stdClass;
$foo = new Foo;
$arr = ['arr' => 'arr'];

var_dump((object)$std);   // no change
var_dump((array)$std);    // no change
var_dump((Foo)$std);      // object of class Foo
var_dump((object)$foo);   // no change
var_dump((stdClass)$foo); // object of class stdClass
var_dump((array)$foo);    // no change
var_dump((array)$arr);    // no change
var_dump((object)$arr);   // no change
var_dump((stdClass)$arr); // object of class stdClass
var_dump((Foo)$arr);      // object of class Foo

Thoughts?

Marc