Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:98515 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 86989 invoked from network); 13 Mar 2017 05:34:44 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 13 Mar 2017 05:34:44 -0000 Authentication-Results: pb1.pair.com smtp.mail=jesseschalken@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=jesseschalken@gmail.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.172 as permitted sender) X-PHP-List-Original-Sender: jesseschalken@gmail.com X-Host-Fingerprint: 74.125.82.172 mail-ot0-f172.google.com Received: from [74.125.82.172] ([74.125.82.172:35003] helo=mail-ot0-f172.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 36/DF-38004-37F26C85 for ; Mon, 13 Mar 2017 00:34:43 -0500 Received: by mail-ot0-f172.google.com with SMTP id x37so106623343ota.2 for ; Sun, 12 Mar 2017 22:34:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:from:date:message-id:subject:to; bh=mFSaVYAnlTCUaIdsJgvSkFwpy1nu+z93qHToijvFBcM=; b=vhtJe9sGUrIr58t/IQUOWxuWuBHOKjAJ19TP82XM2scOUt82HYfN5mDcq/dA4VS+01 NQLVO9uKpSn3Bm0enZa54g413mM1wdR24DaqqrH/riRbrp8ye25FHytPG40EEyY/6AX1 ApBBYdXvN1Y9Z+1HB1RJv2UDv23jS9XWKO6/lvvJcqdHADeFEYYQYpvzGACupARBFQbs xh/wsbYQGx1oM1VoLJWnpr8Mt0jRxpp3IZszM71B1mKvp3wPtGAHVl0bv7LYjGa4eZsH 4Mr4QXT9Rig/b6wvgmg3ipqinWo722zA4k1e11NRyviA47rQQo9tBIzBGbUWWjuewKTv Di1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:from:date:message-id:subject :to; bh=mFSaVYAnlTCUaIdsJgvSkFwpy1nu+z93qHToijvFBcM=; b=fiFj9QuIRTp8LaMVzOZmPk0el59Tr/DSn+8J3h8JlGTDVwaCIaUamaLrrYwRy2LbFk Y0GOv69cV8MZOWmGU75KSdjsAcH4dOLiMq+JuvkKOVZWS8G3Xa0Y/jLrSTBiLlK2YP62 e1win7AwxEk/HxNGbU1NuSq7zmZAdzP353UtWv+ZmHMQ9BmYjN5sqEX2RKns3ksG959/ 2G5m7cmtwVhF8VzrDxysPqcyGV8kEsBVFkN9CAAzJsvFir/bB9gwllmtO9UDkDXxmevu 6xvVhgG3YAlsppKnXmTuFTi68W+iAsaA1xeQINAPpbzUs3h087y9YDJiH469NzEN96HS /Icw== X-Gm-Message-State: AMke39lXP0eGtDpXcR4QkEiXyYDGNWzww0ouHXirIxgrh0UXmPr76shywlMJPEYalzGf9q9PFYegENxK/YU1Ng== X-Received: by 10.157.4.40 with SMTP id 37mr15093230otc.91.1489383280752; Sun, 12 Mar 2017 22:34:40 -0700 (PDT) MIME-Version: 1.0 Sender: jesseschalken@gmail.com Received: by 10.74.37.79 with HTTP; Sun, 12 Mar 2017 22:34:40 -0700 (PDT) Date: Mon, 13 Mar 2017 16:34:40 +1100 X-Google-Sender-Auth: qRRxc9LKh0NTizVLr8giNJ80O5o Message-ID: To: PHP internals Content-Type: multipart/alternative; boundary=001a1136e62062417a054a961120 Subject: array_values should be a no-op for packed layout arrays From: me@jesseschalken.com (Jesse Schalken) --001a1136e62062417a054a961120 Content-Type: text/plain; charset=UTF-8 I noticed this commit recently in HHVM, which makes array_values() return the same array back if it's packed instead of building a copy. My understanding is PHP 7 also has packed arrays like HHVM, and my reading of PHP's array_values() implementation (here ) is that it always creates a copy of the array, even if it's packed. Would this be a worthwhile optimisation to make in PHP as well? --001a1136e62062417a054a961120--