Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:98504
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain fleshgrinder.com from 212.232.25.162 cause and error)
Reply-To: internals@lists.php.net
References: <CAEDdnaXrRnYQ24Dh7RdYmVdiYbBcXjnxo4_B0cNFe=FGewEbvQ@mail.gmail.com>
 <CAEDdnaXFWmC66isyFgB01XJSoG8=wSm0+Hqmgv-DCyERgjKzqw@mail.gmail.com>
 <CAL+t6cHtS5MSCagCaZ4-9A5TrgUF-goeNvUQAV6vpdFbHtUx2A@mail.gmail.com>
 <CAEDdnaVKMED6osCvWgfi6gud7zFdRe5pWio2CXqaYNCXJN33-g@mail.gmail.com>
 <CAL+t6cFdw-t9d7ibByw55N=psGndcm2h=AeCwG6bLfR+Fh_3vQ@mail.gmail.com>
 <CAEDdnaXSnpA0vvh3va1nVbwKRgQc=1DTgec220wpY0LiwxBH7g@mail.gmail.com>
 <CAL+t6cHu0y-m_ObA1gmQBk08AQ6qvwbc=y4Y2OrPhBt5SqcDHw@mail.gmail.com>
 <CAEDdnaW6_EwdjxtQjUVgCSYJDH2UNivvo_bAkY4_DrvH27wBuQ@mail.gmail.com>
 <CAL+t6cF4mU3EN1aH387CN7LCiaKio8WeyEjkLLgWAmBZqMy+pg@mail.gmail.com>
 <CAEDdnaUXghKwjx43b5MmVOiGK8_S=he57sKGd1qzWi_M=AhCaQ@mail.gmail.com>
 <CAL+t6cG=1oTW76j+Gv9xUtnzbVoLfdFEQG1eAHsdjVKMBn+gOA@mail.gmail.com>
 <CAEDdnaXOWwdNfCuP__YSJ7Sh=3yxP95wjezMtTD-70g+S75fYA@mail.gmail.com>
 <60608cfe-5ac3-937b-9184-913f76cde82c@fleshgrinder.com>
 <CAEDdnaUHg74A=mFfqa6fFYvCjzvA9DPk64atfMG9ah6qYwSNbA@mail.gmail.com>
To: Michael Vostrikov <michael.vostrikov@gmail.com>,
 PHP Internals <internals@lists.php.net>
Message-ID: <6ad6bb4d-ba1b-5dc0-2254-58c9b4287144@fleshgrinder.com>
Date: Sun, 12 Mar 2017 11:35:45 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: <CAEDdnaUHg74A=mFfqa6fFYvCjzvA9DPk64atfMG9ah6qYwSNbA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Type variants
From: php@fleshgrinder.com (Fleshgrinder)

On 3/12/2017 11:29 AM, Michael Vostrikov wrote:
> 2017-03-12 14:58 GMT+05:00 Fleshgrinder <php@fleshgrinder.com>:
>> The problem you are facing is that you are dealing with an anemic domain
>> object that does not enforce its own invariants.
>>
> 
> Incomlplete order with date and address not set yet is a valid state of
> order.
> Also, there are many cases when logic which includes many objects is placed
> in a service and not in any of that objects.

Sure, but you should still not have an anemic domain. Any object needs
to ensure its own invariants, that's nothing another service should do.
You are clearly dealing with two kinds of orders, hence, create two
kinds of orders. `IncompleteOrder` is the one without date, address, and
probably even products. You directly named it as such. Then you have
`ProcessableOrder` where this is impossible. **BAM** all problems solved.

On 3/12/2017 11:29 AM, Michael Vostrikov wrote:
> 2017-03-12 14:58 GMT+05:00 Fleshgrinder <php@fleshgrinder.com>:
>> However, you do not require new features to do that.
> 
> I don't tell that we cannot make that with current features. I suggest a
> way to do that more easy. This is like type hinting. We can check types
> manually by calling functions like is_integer() or get_class(), but we
> don't have a question why we need to have type hinting in language.

The problem is that your proposal is meant to solve problems that are
already solved in a way that is not really understood by anyone so far.

-- 
Richard "Fleshgrinder" Fussenegger