Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:98501
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain fleshgrinder.com from 77.244.243.85 cause and error)
Reply-To: internals@lists.php.net
References: <CAEDdnaXrRnYQ24Dh7RdYmVdiYbBcXjnxo4_B0cNFe=FGewEbvQ@mail.gmail.com>
 <CAL+t6cE+N-AEr5+9cduWxaYMZYoCJa-=eZc4wuXrYLjvTbC=AA@mail.gmail.com>
 <CAEDdnaXFWmC66isyFgB01XJSoG8=wSm0+Hqmgv-DCyERgjKzqw@mail.gmail.com>
 <CAL+t6cHtS5MSCagCaZ4-9A5TrgUF-goeNvUQAV6vpdFbHtUx2A@mail.gmail.com>
 <CAEDdnaVKMED6osCvWgfi6gud7zFdRe5pWio2CXqaYNCXJN33-g@mail.gmail.com>
 <CAL+t6cFdw-t9d7ibByw55N=psGndcm2h=AeCwG6bLfR+Fh_3vQ@mail.gmail.com>
 <CAEDdnaXSnpA0vvh3va1nVbwKRgQc=1DTgec220wpY0LiwxBH7g@mail.gmail.com>
 <CAL+t6cHu0y-m_ObA1gmQBk08AQ6qvwbc=y4Y2OrPhBt5SqcDHw@mail.gmail.com>
 <CAEDdnaW6_EwdjxtQjUVgCSYJDH2UNivvo_bAkY4_DrvH27wBuQ@mail.gmail.com>
 <CAL+t6cF4mU3EN1aH387CN7LCiaKio8WeyEjkLLgWAmBZqMy+pg@mail.gmail.com>
 <CAEDdnaUXghKwjx43b5MmVOiGK8_S=he57sKGd1qzWi_M=AhCaQ@mail.gmail.com>
 <CAL+t6cG=1oTW76j+Gv9xUtnzbVoLfdFEQG1eAHsdjVKMBn+gOA@mail.gmail.com>
 <CAEDdnaXOWwdNfCuP__YSJ7Sh=3yxP95wjezMtTD-70g+S75fYA@mail.gmail.com>
To: Michael Vostrikov <michael.vostrikov@gmail.com>
Cc: PHP Internals <internals@lists.php.net>
Message-ID: <60608cfe-5ac3-937b-9184-913f76cde82c@fleshgrinder.com>
Date: Sun, 12 Mar 2017 10:58:27 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: <CAEDdnaXOWwdNfCuP__YSJ7Sh=3yxP95wjezMtTD-70g+S75fYA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Type variants
From: php@fleshgrinder.com (Fleshgrinder)

On 3/12/2017 10:36 AM, Michael Vostrikov wrote:
> Now we need to write in business logic the following:
> 
> function checkout(Order $order)
> {
>     if (count($order->products) > 0) {
>         throw new SomeException1();
>     }
>     if ($order->date === null) {
>         throw new SomeException2();
>     }
>     if ($order->address === null) {
>         throw new SomeException3();
>     }
> 
>     // checkout steps
>     ...
>     someActionWithOrderForCheckout($order);
>     ...
> }
> 
> function someActionWithOrderForCheckout(Order $order)
> {
>     if (count($order->products) > 0) {
>         ...
>     }
>     if ()
>     ...
> }
> 
> 
> Of course, we can move all checks to some function like
> 'ensureOrderIsReadyForCheckout()' and call it everywhere manually.
> But this is the same as call is_integer() manually instead of type hinting.
> 

The problem you are facing is that you are dealing with an anemic domain
object that does not enforce its own invariants. Properly applying OOD
principles would remedy all your problems. However, you do not require
new features to do that.

-- 
Richard "Fleshgrinder" Fussenegger