Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:98499
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.161.169 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAL+t6cG=1oTW76j+Gv9xUtnzbVoLfdFEQG1eAHsdjVKMBn+gOA@mail.gmail.com>
References: <CAEDdnaXrRnYQ24Dh7RdYmVdiYbBcXjnxo4_B0cNFe=FGewEbvQ@mail.gmail.com>
 <CAL+t6cE+N-AEr5+9cduWxaYMZYoCJa-=eZc4wuXrYLjvTbC=AA@mail.gmail.com>
 <CAEDdnaXFWmC66isyFgB01XJSoG8=wSm0+Hqmgv-DCyERgjKzqw@mail.gmail.com>
 <CAL+t6cHtS5MSCagCaZ4-9A5TrgUF-goeNvUQAV6vpdFbHtUx2A@mail.gmail.com>
 <CAEDdnaVKMED6osCvWgfi6gud7zFdRe5pWio2CXqaYNCXJN33-g@mail.gmail.com>
 <CAL+t6cFdw-t9d7ibByw55N=psGndcm2h=AeCwG6bLfR+Fh_3vQ@mail.gmail.com>
 <CAEDdnaXSnpA0vvh3va1nVbwKRgQc=1DTgec220wpY0LiwxBH7g@mail.gmail.com>
 <CAL+t6cHu0y-m_ObA1gmQBk08AQ6qvwbc=y4Y2OrPhBt5SqcDHw@mail.gmail.com>
 <CAEDdnaW6_EwdjxtQjUVgCSYJDH2UNivvo_bAkY4_DrvH27wBuQ@mail.gmail.com>
 <CAL+t6cF4mU3EN1aH387CN7LCiaKio8WeyEjkLLgWAmBZqMy+pg@mail.gmail.com>
 <CAEDdnaUXghKwjx43b5MmVOiGK8_S=he57sKGd1qzWi_M=AhCaQ@mail.gmail.com> <CAL+t6cG=1oTW76j+Gv9xUtnzbVoLfdFEQG1eAHsdjVKMBn+gOA@mail.gmail.com>
Date: Sun, 12 Mar 2017 14:36:19 +0500
Message-ID: <CAEDdnaXOWwdNfCuP__YSJ7Sh=3yxP95wjezMtTD-70g+S75fYA@mail.gmail.com>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=94eb2c0612c0c56b7f054a855368
Subject: Re: [PHP-DEV] Type variants
From: michael.vostrikov@gmail.com (Michael Vostrikov)

--94eb2c0612c0c56b7f054a855368
Content-Type: text/plain; charset=UTF-8

2017-03-12 13:58 GMT+05:00 Sherif Ramadan <theanomaly.is@gmail.com>:

> I think you're trying desperately to find a problem that is fitting of
the proposal

Checks in business logic are popular task.

> If the problem you're trying to solve pertains to object state that I
have no idea how this proposal hopes to achieve that. You can readily
control object state in PHP without the need for declarative types (e.g.
magic getters/setters)

I described in first message the way how the proposal can help with this.
There is no magic getters/setters there.

> Not seeing how this proposal improves or even achieves such a thing.

Now we need to write in business logic the following:

function checkout(Order $order)
{
    if (count($order->products) > 0) {
        throw new SomeException1();
    }
    if ($order->date === null) {
        throw new SomeException2();
    }
    if ($order->address === null) {
        throw new SomeException3();
    }

    // checkout steps
    ...
    someActionWithOrderForCheckout($order);
    ...
}

function someActionWithOrderForCheckout(Order $order)
{
    if (count($order->products) > 0) {
        ...
    }
    if ()
    ...
}


Of course, we can move all checks to some function like
'ensureOrderIsReadyForCheckout()' and call it everywhere manually.
But this is the same as call is_integer() manually instead of type hinting.

--94eb2c0612c0c56b7f054a855368--