Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:98382
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.217.182 as permitted sender)
MIME-Version: 1.0
References: <CAGU04mLB8ourar-_8xQj7Ko8kU-_3cJ5YdVNzFKc3OAdb53eeQ@mail.gmail.com>
 <f2aefba2-741c-2d30-9e01-73c56a84098e@heigl.org> <CAGU04mJnZu9zPqCms1vnxbtr2+77v-wXfSK+AuDJcAu7vpkH9g@mail.gmail.com>
 <fb78c355-29b0-fea2-f4cb-94affcc44782@heigl.org>
In-Reply-To: <fb78c355-29b0-fea2-f4cb-94affcc44782@heigl.org>
Date: Thu, 02 Mar 2017 16:03:55 +0000
Message-ID: <CAGU04mLvihOdNZnLB7v=cEhYmSPxcsDNmz0ZVtx2EQEFLWt29g@mail.gmail.com>
To: Andreas Heigl <andreas@heigl.org>, PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a1143dc861712560549c1947b
Subject: Re: [PHP-DEV] New constants in DateTime
From: crocodile2u@gmail.com (Crocodile)

--001a1143dc861712560549c1947b
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Well, actually, that's a good reason for not having interval constants in
the core. Still think though that SQL formats would be a nice addition ;-)

On Thu, Mar 2, 2017 at 4:57 PM Andreas Heigl <andreas@heigl.org> wrote:

>
> Am 02.03.17 um 16:46 schrieb Crocodile:
> > While I agree with everything you're saying, I also think it could stil=
l
> be
> > worth it to have those constants in core for the following reasons:
> >
> > 1. MINUTE, HOUR and DAY are particularly often used, 99.999% of the tim=
e
> in
> > a context where it does not matter if a minute has 60 seconds or not, o=
r
> if
> > a day has 24h or not. Particularly often used to specify cache lifetime=
,
> > for example.
> IMO they then should be part of the caching (or whatever)-implementation
> and not of DateTime. As *when* they are part of DateTime they will be
> used in a DateTime-context *where they shouldn't be used*!
>
> > 2. It's surely easy to implement them in userland but that would requir=
e
> > either global constants or a class in userland specifically for that
> > purpose. Both ways are easy, but these constants I see in virtually any
> > project, so for me it would be handy to have them in DateTime.
>
> When you need them use a Constant-Class or create a composer package
> that contains your constants and require that.
>
> https://3v4l.org/5MW7O
>
> That's much more extensible than having them in the core and needing to
> maintain them for everyone=E2=80=A6
>
> But as I said: just my 0.02=E2=82=AC
>
> Cheers
>
> Andreas
> >
> > But of course, I don't see it as a must-have, just as nice-to-have.
> >
> > Cheers,
> > Victor
> >
> > On Thu, Mar 2, 2017 at 4:03 PM Andreas Heigl <andreas@heigl.org> wrote:
> >
> >> Hi Victor.
> >>
> >>
> >> Am 02.03.17 um 15:48 schrieb Crocodile:
> >>> Hello internals,
> >>>
> >>> A similar question should have been asked already but I haven't found
> >>> anything so far when googling: I think DateTime class should have the
> >>> following constants in addition to those already existing:
> >>>
> >>> const SQL =3D "Y-m-d H:i:s";
> >>> const SQL_DATE =3D "Y-m-d";
> >>> const SQL_TIME =3D "H:i:s";
> >>> const SECOND =3D 1;
> >>> const MINUTE =3D 60;
> >> Not every minute has 60 seconds.
> >>> const HOUR =3D 3600;
> >> See above!
> >>> const DAY =3D 86400;
> >> Not every day has 86400 seconds. For one see the comment on MINUTE and
> >> also there are days that have more or less than 24 hours (DST)
> >>
> >> Therefore I wouldn't want to see those constants (that are also very
> >> easy to put up in userland - even though they aren't correct) in the
> >> PHP-Core.
> >>
> >> And as the SQL-Constants are also easily to implement in userland I'm
> >> not sure it makes to add them to the core=E2=80=A6
> >>
> >> But that's just my 0.02=E2=82=AC
> >>
> >> Cheers
> >>
> >> Andreas
> >>
> >>
> >> --
> >>                                                               ,,,
> >>                                                              (o o)
> >> +---------------------------------------------------------ooO-(_)-Ooo-=
+
> >> | Andreas Heigl                                                       =
|
> >> | mailto:andreas@heigl.org                  N 50=C2=B022'59.5" E 08=C2=
=B023'58" |
> >> | http://andreas.heigl.org                       http://hei.gl/wiFKy7 =
|
> >> +---------------------------------------------------------------------=
+
> >> | http://hei.gl/root-ca                                               =
|
> >> +---------------------------------------------------------------------=
+
> >>
> >> --
> > Best regards,
> > Victor Bolshov
> >
>
>
> --
>                                                               ,,,
>                                                              (o o)
> +---------------------------------------------------------ooO-(_)-Ooo-+
> | Andreas Heigl                                                       |
> | mailto:andreas@heigl.org                  N 50=C2=B022'59.5" E 08=C2=B0=
23'58" |
> | http://andreas.heigl.org                       http://hei.gl/wiFKy7 |
> +---------------------------------------------------------------------+
> | http://hei.gl/root-ca                                               |
> +---------------------------------------------------------------------+
>
> --
Best regards,
Victor Bolshov

--001a1143dc861712560549c1947b--