Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:98375
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain belski.net from 85.214.73.107 cause and error)
To: "'Dmitry Stogov'" <dmitry@zend.com>,
	"'Nikita Popov'" <nikic@php.net>,
	"'Xinchen Hui'" <laruence@php.net>,
	"'Joe Watkins'" <krakjoe@php.net>
Cc: "'PHP internals list'" <internals@lists.php.net>
References: <005501d28917$c472d9c0$4d588d40$@belski.net> <MWHPR02MB2477C79CFAC186FBF613577EBF5D0@MWHPR02MB2477.namprd02.prod.outlook.com> <00a001d28922$4e320500$ea960f00$@belski.net> <00e501d28b91$03b33280$0b199780$@belski.net>
In-Reply-To: <00e501d28b91$03b33280$0b199780$@belski.net>
Date: Thu, 2 Mar 2017 12:56:46 +0100
Message-ID: <04f901d2934c$13a0d270$3ae27750$@belski.net>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: 7bit
Thread-Index: AQGdeWbJLEby5/ZsPBjtYvSAiRoltAL1j84dAWF3nYUCr3BN0qGzZ2fA
Content-Language: en-us
Subject: RE: [PHP-DEV] Re: Thread safe interned strings
From: anatol.php@belski.net ("Anatol Belski")

Hi,

> -----Original Message-----
> From: Anatol Belski [mailto:anatol.php@belski.net]
> Sent: Monday, February 20, 2017 4:50 PM
> To: 'Dmitry Stogov' <dmitry@zend.com>; 'Nikita Popov' <nikic@php.net>;
> 'Xinchen Hui' <laruence@php.net>; 'Joe Watkins' <krakjoe@php.net>
> Cc: 'PHP internals list' <internals@lists.php.net>
> Subject: RE: [PHP-DEV] Re: Thread safe interned strings
> 
> Hi,
> 
> > > For now, I see one missing part - opcache can't work completely out
> > > of the
> > box,
> > > because its interned string related functions are wrapped with
> > > #ifndef ZTS
> > >
> > Oh, indeed. Getting to this part now then :)
> >
> 
> The Opcache support is done now. Additional things that are done
> 
> - some startup/shutdown sequence refactoring was required in zend.c, to
> mitigate shutdown issues with Opcache
> - CG(zend_string) was removed, instead there is a global variable
> - fixed phpdbg integration
> 
> With this, looks like it's ready for the next review round. I'm doing some
load
> tests in between.
> 
I'm glad to inform, that the interned strings unification patch has reached
the stable state now. It can be found under
https://github.com/php/php-src/pull/2390 . The tests are successful so far
with FCGI and Apache under Linux and Windows. The intention is to merge the
patch into master next days. Additional testing would be great to have, of
course.

Huge thanks to Dmitry for the valuable support!

Regards

Anatol