Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:98370
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.214.54 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <fe709bf6-6686-75b3-168b-1e747813be81@oracle.com>
References: <CADxrgCP4Mt=Jh_zi2qOXEyt2DTbnDFUb2gkxHg8NgeECL5j8_A@mail.gmail.com>
 <CADxrgCMeLA37V=G1WZixE4bos42j6u0AFaM23sJWzuRi+RdefQ@mail.gmail.com>
 <CADyq6sLh_D3JpBn+MrH55N-q=J4ESzgU1EFpm8HKmbaQrvACyg@mail.gmail.com>
 <CADxrgCMrx88RaX0OQhFh-apZ837pcgX7oKA1KHp8t46++wqNkg@mail.gmail.com> <fe709bf6-6686-75b3-168b-1e747813be81@oracle.com>
Date: Wed, 1 Mar 2017 15:00:40 -0500
Message-ID: <CADxrgCMx1P_EFSQ08cQBstqfLe0Hwo1P0m4CSFNOo4kcXteYMg@mail.gmail.com>
To: Christopher Jones <christopher.jones@oracle.com>
Cc: Andrea Faulds <ajf@ajf.me>, Marco Pivetta <ocramius@gmail.com>, 
	"internals@lists.php.net" <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=94eb2c088fb85c67bb0549b0c4b4
Subject: Re: [PHP-DEV] Re: [RFC] Extended String Types For PDO
From: adam.baratz@gmail.com (Adam Baratz)

--94eb2c088fb85c67bb0549b0c4b4
Content-Type: text/plain; charset=UTF-8

>
> Isn't the same quoting functionality available via the quote() method?
> That's what the PR's tests use.
>

> I don't think it's orthogonal.  There are various ways to quote strings
> and a generic PDO solution should be flexible enough to handle all drivers.
>

Yes, they fit into the same general topic of string quoting, but I'd assign
different levels of importance to national charset literals and alternate
delimiters. Not being able to quote national charset literals means you
can't produce correctly formed queries with two drivers. My understanding
of alternate delimiters is that they make it easier to hand-writing
queries. The quote function may not generate the most human-readable
queries for some input, but the queries will be valid.

There are a couple other complexities for alternate delimiters. Not all
databases allow them and the options vary for each. For example,
PostgreSQL's only alternative is dollar-quoting[1]. If you think it's
important to handle this functionality, I think a separate RFC would be
more appropriate. My guess is instance/statement attributes would be the
better mechanism to control delimiters and you might want them to be
driver-specific.

Thanks,
Adam

---
[1]
https://www.postgresql.org/docs/9.2/static/sql-syntax-lexical.html#SQL-SYNTAX-DOLLAR-QUOTING

--94eb2c088fb85c67bb0549b0c4b4--