Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:98360
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain oracle.com from 141.146.126.69 cause and error)
To: Adam Baratz <adam.baratz@gmail.com>
References: <CADxrgCP4Mt=Jh_zi2qOXEyt2DTbnDFUb2gkxHg8NgeECL5j8_A@mail.gmail.com>
 <CADxrgCMeLA37V=G1WZixE4bos42j6u0AFaM23sJWzuRi+RdefQ@mail.gmail.com>
 <CADyq6sLh_D3JpBn+MrH55N-q=J4ESzgU1EFpm8HKmbaQrvACyg@mail.gmail.com>
Cc: "internals@lists.php.net" <internals@lists.php.net>
Message-ID: <98c2a0bb-c03a-a1ba-75f2-b6210709aa81@oracle.com>
Date: Tue, 28 Feb 2017 15:14:43 +1100
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:45.0)
 Gecko/20100101 Thunderbird/45.7.1
MIME-Version: 1.0
In-Reply-To: <CADyq6sLh_D3JpBn+MrH55N-q=J4ESzgU1EFpm8HKmbaQrvACyg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Re: [RFC] Extended String Types For PDO
From: christopher.jones@oracle.com (Christopher Jones)

On 26/2/17 9:07 am, Marco Pivetta wrote:

> Hi Adam
>
> On Fri, Feb 24, 2017 at 2:28 PM, Adam Baratz <adam.baratz@gmail.com> wrote:
>
>>> Based on some pain points with my team and things I've heard from others,
>>> I created an RFC to handle "national" character sets for emulated
>> prepared
>>> statements:
>>> https://wiki.php.net/rfc/extended-string-types-for-pdo
>>>
>>> I had previously suggested this as a driver-specific change, but believe
>>> it's worthwhile to make it generic since it affects multiple drivers:
>>> https://externals.io/thread/400#email-12542
>>>
>>> Please let me know what you think.
>>>
>>> Thanks,
>>> Adam
>>>
>> Any thoughts on this one?
>>
> DBAL maintainer here: before we introduce even more complexity into the PDO
> stuff (which is already a maze), could a set of test cases be written, so
> that stuff that is currently impossible to do without this RFC is
> clearer/demonstrated?
>
> I'm asking because we didn't get any bug reports about extended string
> types for Doctrine DBAL, and adding new types just to workaround the
> limitations of the usual suspects (remember that PDO for SQLServer is
> experimental, if not totally unusable) is shotgun surgery, and just more
> complexity to handle.
>
> Greets,
>
> Marco Pivetta
>
> http://twitter.com/Ocramius
>
> http://ocramius.github.com/
>
I agree the spec could definitely do with some samples and detail.

At a start, what about defining 'N-prefix' so the reader doesn't have to trawl through references?!
And clarify whether the PR is for the generic solution or the earlier problem.

More importantly, what about allowing arbitrary quote delimiters?
https://livesql.oracle.com/apex/livesql/file/content_CIREYU9EA54EOKQ7LAMZKRF6P.html

Chris

-- 
http://twitter.com/ghrd